This fixes a null-pointer dereference in tls_ctx_cert_time(), which will
occur on clients that do not use a client certificate (ie that only have
auth-user-pass in the config, but no key and cert). This bug was
introduced by commit 091edd8e on the master branch, and commit dfd940bb
on the release/
This fixes a null-pointer dereference in tls_ctx_cert_time(), which will
occur on clients that do not use a client certificate (ie that only have
auth-user-pass in the config, but no key and cert). This bug was
introduced by commit 091edd8e on the master branch, and commit dfd940bb
on the release/
ACK, thanks.
Your patch has been applied to the master and release/2.3 branch.
commit 868d9d01802da93a758981f3c7310a905813 (master)
commit f4bf11daa8d659e74915c308930145963867d64c (master)
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Sun Jan 3 10:47:56 2016 +
Hi Arne,
Some final comments (mostly just nitpicking). Other than this, I think
the patch is ready to be merged. I tested it against James' openvpn 3
test server.
On 02-01-16 11:20, Arne Schwabe wrote:
+static void
+lz4_compress (struct buffer *buf, struct buffer work,
+ struct
Patch V2: Fix minor issues found by Steffan
Patch V3: split wire codes and compression flags
Patch V4: Fix further issues reported by Gert
Patch V5: really fix the issues that should be fixed in v2
It has been tested against v3 server and again itself. From James Mail:
Compression V2
I have
Patch V2: Fix minor issues found by Steffan
Patch V3: split wire codes and compression flags
Patch V4: Fix further issues reported by Gert
Patch V5: really fix the issues that should be fixed in v2
Patch V6: fix more minor things
It has been tested against v3 server and again itself. From James Ma
On Sun, Jan 3, 2016 at 6:27 PM, Arne Schwabe wrote:
> + /* did compression save us anything? Include 2 byte compression header
> + in calculation */
> + {
> +if (compressed && work.len + 2 < buf->len)
> + {
> + ASSERT(buf_prepend(&work, 2));
> + uint8_t *head = BPTR (&w