[Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
This adds a macro file with a permissive license. Its small so I don't mind inlining the macro into configure.ac if that is preferred. ---8< Makes configure tests for Windows API neater and consistent. Signed-off-by: Selva Nair --- check_symbols_in.m4 | 43

[Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Signed-off-by: Selva Nair --- check_symbols_in.m4 | 43 +++ configure.ac| 17 + 2 files changed, 52 insertions(+), 8 deletions(-) create mode 100644 check_symbols_in.m4 diff --git a/check_symbols_in.m4 b/check_symbols_in.m4 new

[Openvpn-devel] [PATCH] Make default dhcp server ip offset = 0 for subnet topology

2015-12-07 Thread Selva Nair
This makes the default choice for the emulated dhcp server address to be the network address, same as in the TAP mode. Also change the default ifconfig_pool_end to broadcast - 1. Currently the default ip for the dhcp server is the broadcast address - 1, making that address not available for window

Re: [Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Gert Doering
Hi, On Sun, Dec 06, 2015 at 07:01:46PM -0500, Selva Nair wrote: > This adds a macro file with a permissive license. Its small so I don't > mind inlining the macro into configure.ac if that is preferred. > ---8< This looks interesting, but I'm not convinced that this actually *works* -

Re: [Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Gert Doering
Hi, On Sun, Dec 06, 2015 at 07:01:47PM -0500, Selva Nair wrote: > Signed-off-by: Selva Nair NAK for 2.3 - what we have there works well enough. Prettyfying things will only be done in master (unless the 2.3 stuff does not *work*, in which case "cleanup when fixing bugs" is fine - but it does

Re: [Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Hi, > On Sun, Dec 06, 2015 at 07:01:47PM -0500, Selva Nair wrote: > > Signed-off-by: Selva Nair > > NAK for 2.3 - what we have there works well enough. > The reason for adding it to 2.3 was anticipating it will have to be built for vista+ if the dns-leak patch goes in. In fact I wrote it the i

Re: [Openvpn-devel] [PATCH 2.3] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Gert Doering
Hi On Mon, Dec 07, 2015 at 10:10:55AM -0500, Selva Nair wrote: > > On Sun, Dec 06, 2015 at 07:01:47PM -0500, Selva Nair wrote: > > > Signed-off-by: Selva Nair > > > > NAK for 2.3 - what we have there works well enough. > > The reason for adding it to 2.3 was anticipating it will have to be built

Re: [Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Hi, If it was such a sucker, I wouldn't have posted it :) The innards of an autoconf macro could be unnerving, but please try it. On Mon, Dec 7, 2015 at 2:16 AM, Gert Doering wrote: > Hi, > > On Sun, Dec 06, 2015 at 07:01:46PM -0500, Selva Nair wrote: > > This adds a macro file with a permissi

Re: [Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Gert Doering
Hi, On Mon, Dec 07, 2015 at 10:31:39AM -0500, Selva Nair wrote: > > This looks interesting, but I'm not convinced that this actually *works* - > > the reason why I had to add an explicit compile test is that the standard > > configure.ac test will claim "inet_pton is not there" because the way > >

Re: [Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Hi, > > > AC_CHECK_DECL would detect inet_pton etc., because it only looks for the > > declaration in a header. The macro I submitted works almost exactly like > > AC_CHECK_DECL but defines HAVE_symbol instead of HAVE_DECL_symbol. > > Not good enough. I want to be sure that the symbol is there,

Re: [Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Hi, >> > > Which environments did you test this on? It needs to work on mingw as >> > I use debian jessie, but it should work elsewhere. >> > >> > > shipped with ubuntu 12.04 (no inet_pton), mingw as shipped with 14.04 >> > > (inet_pton, *and* the definition its using conflicts with our compat/

Re: [Openvpn-devel] [PATCH master] Add an autoconf macro to check WINAPI functions

2015-12-07 Thread Selva Nair
Hi, Sorry for the piece-meal replies. On Mon, Dec 7, 2015 at 10:47 AM, Gert Doering wrote: > > AC_CHECK_DECL would detect inet_pton etc., because it only looks for the > > declaration in a header. The macro I submitted works almost exactly like > > AC_CHECK_DECL but defines HAVE_symbol instead