[Openvpn-devel] [PATCH applied] Re: Make __func__ work with Visual Studio too

2015-07-02 Thread Gert Doering
ACK. Your patch has been applied to the master and release/2.3 branch. commit 9884e20810bda737c7708ff587e09cc0bb8475c7 (master) commit 4188a2dcdc32d36ccbd85396cf40d54d75e2ca3e (release/2.3) Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Wed Jul 1 23:25:56 2015 +0200

[Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Jan Just Keijser
Attached is the patch to add the TFTP and WPAD DHCP options. The patch is based on openvpn 2.3.7 as I did not know how to do a windows mingw build of the git version ... The patch was tested on Windows XP 32bit and Windows 7sp1 64bit. A 64bit windows binary can be found @ http://www.nikhef.nl/~

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Jonathan K. Bullard
On Thu, Jul 2, 2015 at 2:56 AM, Jan Just Keijser wrote: > Attached is the patch to add the TFTP and WPAD DHCP options. The patch > is based on openvpn 2.3.7 as I did not know how to do a windows mingw > build of the git version ... > The patch was tested on Windows XP 32bit and Windows 7sp1 64bit.

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Jan Just Keijser
Hi, On 02/07/15 14:16, Jonathan K. Bullard wrote: On Thu, Jul 2, 2015 at 2:56 AM, Jan Just Keijser wrote: Attached is the patch to add the TFTP and WPAD DHCP options. The patch is based on openvpn 2.3.7 as I did not know how to do a windows mingw build of the git version ... The patch was test

Re: [Openvpn-devel] [PATCH] Add TFTP and WPAD DHCP options

2015-07-02 Thread Gert Doering
Hi, On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote: > +write_dhcp_str (buf, 66, o->tftp, &error); > +write_dhcp_str (buf, 150, o->tftp, &error); This does not look safe to me (or I'm overlooking something) - if o->tftp is not set, it will do "strlen(o->tftp)" inside wri

Re: [Openvpn-devel] [PATCH v2] Add TFTP and WPAD DHCP options

2015-07-02 Thread Jan Just Keijser
Hi, Gert Doering wrote: Hi, On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote: +write_dhcp_str (buf, 66, o->tftp, &error); +write_dhcp_str (buf, 150, o->tftp, &error); This does not look safe to me (or I'm overlooking something) - if o->tftp is not set, it wil