[Openvpn-devel] [PATCH applied] Re: patch for bug #93: up-restart env vars

2015-05-23 Thread Gert Doering
ACK. Your patch has been applied to the master and release/2.3 branches. I have taken a few liberties here - namely, merging the openvpn.8 patch into yours as it's sort sort of "one big change" anyway, and reformatting do_ifconfig_setenv() according to our new and improved coding style (it didn't

[Openvpn-devel] [PATCH] Re-read auth-user-pass file on (re)connect if required

2015-05-23 Thread Steffan Karger
Fixes trac #225 ('--auth-user-pass FILE' and '--auth-nocache' problem). This patch is based on the changes suggested by ye_olde_iron in the trac ticket. Also added a note to the manpage to inform people to use absolute paths when combining --auth-user-pass file and --auth-nocache. Signed-off-by:

[Openvpn-devel] [PATCH] repair --dev null breakage caused by db950be85d37

2015-05-23 Thread Gert Doering
"make check" self-test was broken after commit db950be85d37 due to do_ifconfig_setenv() not checking whether tt->did_ifconfig_setup was set (which isn't, for "dev null" type setups) Signed-off-by: Gert Doering --- src/openvpn/tun.c | 24 ++-- 1 file changed, 14 insertions(+),

Re: [Openvpn-devel] [PATCH] repair --dev null breakage caused by db950be85d37

2015-05-23 Thread Steffan Karger
ACK On Sat, May 23, 2015 at 8:01 PM, Gert Doering wrote: > "make check" self-test was broken after commit db950be85d37 due to > do_ifconfig_setenv() not checking whether tt->did_ifconfig_setup > was set (which isn't, for "dev null" type setups) > > Signed-off-by: Gert Doering > --- > src/openvp

Re: [Openvpn-devel] [PATCH] repair --dev null breakage caused by db950be85d37

2015-05-23 Thread Gert Doering
Hi, On Sat, May 23, 2015 at 08:01:38PM +0200, Gert Doering wrote: > "make check" self-test was broken after commit db950be85d37 due to > do_ifconfig_setenv() not checking whether tt->did_ifconfig_setup > was set (which isn't, for "dev null" type setups) Applied to master and release/2.3 branches.

[Openvpn-devel] [PATCH applied] Re: cleanup: remove md5 helper functions

2015-05-23 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 827de237860813d2859aaae3aca292d42a9c2a82 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sun May 3 17:07:11 2015 +0200 cleanup: remove md5 helper functions Signed-off-by: Steffan Karger A

[Openvpn-devel] [PATCH applied] Re: Re-read auth-user-pass file on (re)connect if required

2015-05-23 Thread Gert Doering
ACK. Your patch has been applied to the master and release/2.3 branch. commit ac1cb5bfbb9e09e79fd737bc57999d968d77c5ad (master) commit 6f789d2ec6b6aacb46ab27f148c6981faab6 (release/2.3) Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sat May 23 15:02:25 2015 +02

[Openvpn-devel] [Patch] Fix null pointer dereference in options.c

2015-05-23 Thread Jonathan K. Bullard
(At Gert's request, I am posting this to openvpn-devel.) This patch fixes a null pointer dereference in options.c. Below are versions for openvpn-master and openvpn-2.3; they differ only in the line number reference. 2.3 branch diff -U 4 -r openvpn-release-2.3/src/openvpn/optio

[Openvpn-devel] [PATCH applied] Re: assume res_init() is always there.

2015-05-23 Thread Gert Doering
Lazy-ACKed - tested on almost all supported OSes, no objections for nearly four weeks (and general support in the discussion beforehand). Patch has been applied to the master and release/2.3 branches. commit 403dc434d245e5df5ae262935aa2e7364547e260 (master) commit ae9aff25c5a74e770a29a3a675f5b8f8

[Openvpn-devel] [PATCH applied] Re: Fix null pointer dereference in options.c

2015-05-23 Thread Gert Doering
ACK. Your patch has been applied to the master and release/2.3 branch. commit 025d611fc68aa0c651c391bd6178d062246f36f0 (master) commit 4bdcf450b66f8a8da2c030815097830494b55fc4 (release/2.3) Author: Jonathan K. Bullard List-Post: openvpn-devel@lists.sourceforge.net Date: Sat May 23 15:33:21 2015

[Openvpn-devel] [PATCH] Correct note about DNS randomization in openvpn.8

2015-05-23 Thread Gert Doering
Commit 4880739c17b502d00a removed DNS randomization, but this fact never made it into the man page. Trac #411 Signed-off-by: Gert Doering --- doc/openvpn.8 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 56e7e80..f6e910c 100644 --- a

[Openvpn-devel] [PATCH (master)] Correct note about DNS randomization in openvpn.8

2015-05-23 Thread Gert Doering
Commit 4880739c17b502d00a removed DNS randomization, and the dual-stack patches for 2.4 completely changed the getaddrinfo() result handling again, but neither fact ever made it into the man page. Trac #411 Signed-off-by: Gert Doering --- doc/openvpn.8 | 13 ++--- 1 file changed, 10 ins

Re: [Openvpn-devel] [PATCH] Correct note about DNS randomization in openvpn.8

2015-05-23 Thread Arne Schwabe
Am 23.05.15 um 22:47 schrieb Gert Doering: > Commit 4880739c17b502d00a removed DNS randomization, but this fact > never made it into the man page. > > ACK