Both functions had almost exactly the same code. Instead of the code
duplication, have key_state_write_plaintext() call
key_state_write_plaintext_const() to do the actual work. This is just
a bit of cleanup, it should not change any behaviour.
Signed-off-by: Steffan Karger
---
src/openvpn/ssl_
Hi,
On Sun, May 03, 2015 at 11:23:38AM +0200, Steffan Karger wrote:
> Both functions had almost exactly the same code. Instead of the code
> duplication, have key_state_write_plaintext() call
> key_state_write_plaintext_const() to do the actual work. This is just
> a bit of cleanup, it should no
Sorry, I indeed have a few more commits in between in my local tree. In
particaly, the polarssl logging improvements. Attached a rebase version
of the previous patch.
(Let's see if I got the reply-to stuff in git send-email correct...)
-Steffan
Both functions had almost exactly the same code. Instead of the code
duplication, have key_state_write_plaintext() call
key_state_write_plaintext_const() to do the actual work. This is just
a bit of cleanup, it should not change any behaviour.
Signed-off-by: Steffan Karger
---
src/openvpn/ssl_
ACK.
Your patch has been applied to the master branch (doesn't want to be
cherry-picked into release/2.3)
commit 23b6ba6378bf3a3f5ceb828c8a4dd7cc38947d07 (master)
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Sun May 3 14:06:01 2015 +0200
polarssl: remove co
The MD5 wrapper functions were used in just a few places, which imho is
not worth the extra code. Instead of using these wrappers, just use
the generic md_ctx_*() functions directly.
The md5sum() function was only used for logging information that was not
useful to a user; first the full options
Hi Jonathan,
On 17-04-15 11:28, Jonathan K. Bullard wrote:
I would like to propose a patch which complains if OpenVPN options
include parameters that are not expected.
If possible, I would like to get a "feature ACK" consensus before I
create the patch. (If I get a "feature NAK" then I won't cr
