Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: > Release pCertName, if SecCertificateCopyValues() fails. > > Found via cppcheck. > > Signed-off-by: Yegor Yefremov > Cc: Vasily Kulikov Acked-by: Vasily Kulikov Thank you! > --- > contrib/keychain-mcd/cert_data.c | 1 + > 1 file c

Re: [Openvpn-devel] [PATCH] Fix autotools check for res_init (#523)

Hi, On Fri, Mar 06, 2015 at 01:07:38PM -0600, Nicholas Hall wrote: > Autotools configure check fails to detect res_init on recent glibc > versions. It appears that resolv.h in recent glibc maps res_init to > __res_init which autotools doesn't catch. Coming back to this. I agree this needs fixin

[Openvpn-devel] [PATCH] Fix leftover 'if (false) ;' statements

Commit a4b8f653ee5be9c2292c removed the #ifdefs for ENABLE_HTTP_PROXY and ENABLE_SOCKS, thus making this "if (false) ; else if (...)" construct superfluous. Spotted by David Sommerseth. Signed-off-by: Gert Doering --- src/openvpn/socket.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletio