So the vote goes clearly to #defines, right?
I'm going to change the code and test it. If it works, the change will
be included in the next patch.
Best regards,
Holger
Am 18.06.2014 23:07, schrieb David Sommerseth:
I see and understands the arguments for using static const, and it
surely ha
Hello David,
thanks for taking time and reviewing and testing the code.
Am 23.06.2014 16:23, schrieb David Woodhouse:
Looking over the patches first... they make the client work in OEM or
Unicode mode according to what the server asks for... but then only ever
admit to supporting Unicode mode
On Tue, 2014-06-24 at 18:46 +0200, Holger Kummert wrote:
> Hello David,
>
> thanks for taking time and reviewing and testing the code.
>
> Am 23.06.2014 16:23, schrieb David Woodhouse:
> > Looking over the patches first... they make the client work in OEM or
> > Unicode mode according to what the
PolarSSL support has been extended and adjusted, but README.polarssl was
not accordingly adjusted. This updates README.polarssl to the current state
of affairs for OpenVPN 2.3.
Signed-off-by: Steffan Karger
---
README.polarssl | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
PolarSSL support has been extended and adjusted, but README.polarssl was
not accordingly adjusted. This updates README.polarssl to the current state
of affairs for the master branch.
Signed-off-by: Steffan Karger
---
README.polarssl | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
Your patch has been applied to the master and release/2.3 branches.
commit e238b806f5f3843b80d5b1b2b269679210faa7f6 (master)
commit 991e3574dd9d11dac61b302377b29d24a46b89b1 (release/2.3)
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Fri Apr 25 10:41:17 2014 +0200
ACK. Patch has been applied to the master branch.
commit 96b9538711789355472607922ab1a0ac6d151367
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Tue Jun 24 22:03:26 2014 +0200
Update README.polarssl
Signed-off-by: Steffan Karger
Acked-by: Gert Doeri
ACK. Patch has been applied to the release/2.3 branch.
commit f7048855c0f4d1045181cfbc24381c786a9ace31
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Tue Jun 24 22:03:25 2014 +0200
Update README.polarssl
Signed-off-by: Steffan Karger
Acked-by: Gert
Hi,
On Tue, Jun 24, 2014 at 06:15:20PM +0200, Holger Kummert wrote:
> So the vote goes clearly to #defines, right?
Yes, please. Not because it's necessarily "better", but because it's what
the rest of the code currently uses. (As with all styleguides, personal
taste will differ in places... I
