[Openvpn-devel] [PATCH] Minor cleanup

2014-06-01 Thread Steffan Karger
Hi, The following patches contain some minor clean up of stuff I came along while working on other parts. They do not change behaviour. -Steffan

[Openvpn-devel] [PATCH 1/5] Use generic openvpn_x509_cert_t in ssl_verify_polarssl.c

2014-06-01 Thread Steffan Karger
For symmetry with ssl_verify_openssl.c and release/2.3 branch. Signed-off-by: Steffan Karger --- src/openvpn/ssl_verify_polarssl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/ssl_verify_polarssl.c b/src/openvpn/ssl_verify_polarssl.c index 1d622cc..71d38a9

[Openvpn-devel] [PATCH 2/5] Fix ssl.c, ssl_verify_* includes

2014-06-01 Thread Steffan Karger
* ssl.c: remove three unneeded includes * ssl_verify_polarssl.h: remove two unneeded includes * ssl_verify_openssl.c: add missing ssl_verify_openssl.h and error.h includes, and reorder includes. Signed-off-by: Steffan Karger --- src/openvpn/ssl.c | 4 src/openvpn/ssl_verif

[Openvpn-devel] [PATCH 4/5] Remove dependency on manage.h from ssl_verify.h

2014-06-01 Thread Steffan Karger
verify_user_pass_enabled() is a function on a tls_session, and belongs in ssl.c. Moving the function removes the dependency on manage.h. Signed-off-by: Steffan Karger --- src/openvpn/ssl.c| 21 - src/openvpn/ssl_verify.h | 20 2 files changed, 20

[Openvpn-devel] [PATCH 3/5] Move #include "ssl_verify.h" from ssl.h to the source files that need it.

2014-06-01 Thread Steffan Karger
Signed-off-by: Steffan Karger --- src/openvpn/forward.c | 1 + src/openvpn/init.c| 1 + src/openvpn/multi.c | 1 + src/openvpn/options.c | 1 + src/openvpn/pf.c | 2 +- src/openvpn/push.c| 1 + src/openvpn/ssl.h | 1 - 7 files changed, 6 insertions(+), 2 deletions(-) diff --gi

[Openvpn-devel] [PATCH 5/5] Remove unused variable 'proxy' from socket_restart_pause()

2014-06-01 Thread Steffan Karger
Variable 'proxy' was set but never read, so remove it. Signed-off-by: Steffan Karger --- src/openvpn/init.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 021b5ca..76b1bbe 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -1

[Openvpn-devel] [PATCH applied] Re: Use generic openvpn_x509_cert_t in ssl_verify_polarssl.c

2014-06-01 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit a87c0a9624d5fb28930d9d137ba9dbd8a2515caf Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Jun 1 19:58:52 2014 +0200 Use generic openvpn_x509_cert_t in ssl_verify_polarssl.c Signed-off-by: Ste

[Openvpn-devel] [PATCH applied] Re: Fix ssl.c, ssl_verify_* includes

2014-06-01 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 67bdede662a90c33502b4f6ed5fac088e90c681a Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Jun 1 19:58:53 2014 +0200 Fix ssl.c, ssl_verify_* includes Signed-off-by: Steffan Karger Acked-

[Openvpn-devel] [PATCH applied] Re: Move #include ssl_verify.h from ssl.h to the source files that need it.

2014-06-01 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 63dc03d068550a6d544ae3b5f489f71c247332eb Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Jun 1 19:58:54 2014 +0200 Move #include ssl_verify.h from ssl.h to the source files that need it. Sig

[Openvpn-devel] [PATCH applied] Re: Remove dependency on manage.h from ssl_verify.h

2014-06-01 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 3ba6b9ff1a50800dfea55d33d9be53c77b50d307 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Jun 1 19:58:55 2014 +0200 Remove dependency on manage.h from ssl_verify.h Signed-off-by: Steffan Karg

[Openvpn-devel] [PATCH applied] Re: Remove unused variable 'proxy' from socket_restart_pause()

2014-06-01 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 55af8e9a4138db0c9de6f6e29dec9839231ec798 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Jun 1 19:58:56 2014 +0200 Remove unused variable 'proxy' from socket_restart_pause() Signed-off-by: S

[Openvpn-devel] [PATCH applied] Re: Add (default disabled) --enable-werror option to configure

2014-06-01 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 51194ffd1983f67b204348686f0ea358f29fe550 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Thu May 29 12:39:07 2014 +0200 Add (default disabled) --enable-werror option to configure Signed-off-by: