[Openvpn-devel] Questionable restriction in --x509-username-field

The X.509 user certificates in our organization have Subject fields that appear as in the following example: Subject: O=Hewlett-Packard Company, OU=WEB, CN=GivenName Surname/emailAddress=u...@hp.com Since the Common Name (CN) attribute is not guaranteed to be unique across the company but the

Re: [Openvpn-devel] Questionable restriction in --x509-username-field

Hi Andris, On 08/05/14 03:32, Andris Kalnozols wrote: The X.509 user certificates in our organization have Subject fields that appear as in the following example: Subject: O=Hewlett-Packard Company, OU=WEB, CN=GivenName Surname/emailAddress=u...@hp.com Since the Common Name (CN) attribut

Re: [Openvpn-devel] Questionable restriction in --x509-username-field

On 5/7/2014 10:06 PM, Jan Just Keijser wrote: > Hi Andris, > > On 08/05/14 03:32, Andris Kalnozols wrote: >> The X.509 user certificates in our organization have Subject fields >> that appear as in the following example: >> >>Subject: O=Hewlett-Packard Company, OU=WEB, >>CN=GivenName Surn

Re: [Openvpn-devel] Questionable restriction in --x509-username-field

Hi Andris, Kalnozols, Andris wrote: On 5/7/2014 10:06 PM, Jan Just Keijser wrote: On 08/05/14 03:32, Andris Kalnozols wrote: The X.509 user certificates in our organization have Subject fields that appear as in the following example: Subject: O=Hewlett-Packard Company, OU=WEB, C

[Openvpn-devel] MSVC Fixes for 2.3

This series of patches is for the 2.3 branch and fixes MSVC compile issues. Some of these may be applicable to master as well, though I haven't checked yet. James

[Openvpn-devel] [PATCH 1/6] Fixed several instances of declarations after statements.

Signed-off-by: James Yonan --- src/openvpn/init.c | 10 ++ src/openvpn/socket.c | 2 +- src/openvpn/win32.c | 6 +++--- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 52d370b..3fb 100644 --- a/src/openvpn/init.c +++ b

[Openvpn-devel] [PATCH 2/6] In socket.c, fixed issue where uninitialized value (err) is being passed to to gai_strerror.

Signed-off-by: James Yonan --- src/openvpn/socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 7ff14cc..6e68c18 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -1150,7 +1150,6 @@ resolve_bind_local (struc

[Openvpn-devel] [PATCH 3/6] Explicitly cast the third parameter of setsockopt to const void * to avoid warning.

Signed-off-by: James Yonan --- src/openvpn/socket.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/socket.h b/src/openvpn/socket.h index 4e7e7f8..793cd9f 100644 --- a/src/openvpn/socket.h +++ b/src/openvpn/socket.h @@ -1023,7 +1023,7 @@ static inline void link_so

[Openvpn-devel] [PATCH 4/6] MSVC 2008 doesn't support dimensioning an array with a const var nor using %z as a printf format specifier.

Signed-off-by: James Yonan --- src/openvpn/ssl_openssl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 481600a..d845fd7 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -261,8 +261,7

[Openvpn-devel] [PATCH 5/6] Define PATH_SEPARATOR for MSVC builds.

Signed-off-by: James Yonan --- config-msvc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config-msvc.h b/config-msvc.h index 9a95ae6..fa99384 100644 --- a/config-msvc.h +++ b/config-msvc.h @@ -76,6 +76,9 @@ #define HAVE_OPENSSL_ENGINE 1 +#define PATH_SEPARATOR '\\' +#define PATH

[Openvpn-devel] [PATCH 6/6] Fixed some compile issues with show_library_versions()

* Refactored show_library_versions to work around the fact that some compilers (such as MSVC 2008) can't handle #ifdefs inside of macro references. * Declare show_library_versions() in options.h because it's referenced by other files such as openvpn.c. * Declare get_ssl_library_version() as