ACK, with the explanation given on IRC:
13:54 <@plai> that patch is FOSDEM last year time
13:58 <@plai> Something could fail with an msg (M_FATAL, which calls then
openvpn_exit with calls the exit script hook, which fails if the
env is not available
Your patch has b
ACK. This has limited impact on "the core" as it's all #ifdef ANDROID
only - and is obviously necessary changes, as well contained as possible.
I have amended the commit message somewhat to make it more clear what
the patch does.
Patch has been applied to the master branch.
commit c058cbffc182b
ACK. Useful feature, limited side-effects, and has been lingering way too
long on the list without anyone protesting it (=lazy ACK applies as well)
Patch has been applied to the master branch.
commit 8f7d5e671a49a316a5fd6392f480d51533fc2747
Author: Arne Schwabe
List-Post: openvpn-devel@lists.s
Hi,
On Tue, Mar 18, 2014 at 05:40:41PM +0100, Steffan Karger wrote:
> > So it seems I spoke too soon... sorry for the noise, although I must
> > say that I'm still in favour of checking for the existence of an IFDEF
> > instead of relying on a particular version...
>
> Point taken, just checking
