Re: [Openvpn-devel] [PATCH] Fix file checks when --chroot is being used

2013-11-26 Thread David Sommerseth
On 23. nov. 2013 10:53, Steffan Karger wrote: > Hi David, > > This solution looks good. I did not test, but I do have one minor > comment after glancing at the code: > > @@ -2662,7 +2700,14 @@ check_cmd_access(const char *command, const > char *opt) * only requires X_OK to function on Unix - a scen

Re: [Openvpn-devel] [PATCH] Fix file checks when --chroot is being used

2013-11-26 Thread Gert Doering
Hi, On Tue, Nov 26, 2013 at 12:15:09PM +0100, David Sommerseth wrote: > and Gert will apply whatever gets an ACK I presume :) ACK! :) (On that statement, not on the patch, all my brains are focused on the dual-stack patch set) gert -- USENET is *not* the non-clickable part of WWW!

[Openvpn-devel] [PATCH applied] Re: Split link_socket_init_phase2 into smaller more managable/readable functions. No functional changes

2013-11-26 Thread Gert Doering
ACK. This really is just moving code bits around without any actual change I could spot. And it passes my test rig :-) Patch has been applied to the master branch, with some whitespace fixes. commit 48f1d41a80b1f2aa9e47b38f645dc880bd7090a4 Author: Arne Schwabe List-Post: openvpn-devel@lists.so

[Openvpn-devel] [PATCH applied] Re: Change remote the proto_remote function to return a constant string

2013-11-26 Thread Gert Doering
ACK. Code and feature. Patch has been applied to the master branch, with some textual cleanup applied to the commit message. commit 34136dd8533510f68a012ba9e6bcd8cf5d1ce80e (master) Author: Arne Schwabe List-Post: openvpn-devel@lists.sourceforge.net Date: Mon Nov 25 13:31:13 2013 +0100

[Openvpn-devel] [PATCH applied] Re: Remove the ip-remote-hint option.

2013-11-26 Thread Gert Doering
ACK. Feature-ACK agreed in Munich, on the assumption that it will eventually come back as an alias of "--resolve-remotes-at-startup ". Right now, the feature just gets in the way of the dual-stack changes. Code-ACK. Looks simple enough, and passes my t_client tests :-) Patch has been applie