[Openvpn-devel] [PATCH applied] Re: Split the PROTO_UDP_xx options into AF_INET/AF_INET6 and PROTO_TCP/PROTO_UDP part.

2013-11-24 Thread Gert Doering
ACK. I have fixed a few bits of whitespace, and one occurrence of proto2ascii() where the second parameter wasn't "proto.af". Patch with those changes has been applied to the master branch. commit 30077d1f415b8dc9bd7c8a1ac6a7585136ac6261 (master) Author: Arne Schwabe List-Post: openvpn-devel@li

[Openvpn-devel] [PATCH] Change remote the proto_remote function to return a constant string

2013-11-24 Thread Arne Schwabe
Instead of using the implicit protocol string that is returned by the proto/af to names function return a constant string. The strings have become part of the wire protocl and we do not want them to change we the printing of proto/af changes. --- src/openvpn/options.c | 2 +- src/openvpn/socket.

[Openvpn-devel] [PATCH applied] Re: Fix two instances of asserting AF_INET

2013-11-24 Thread Gert Doering
ACK. I have applied this patch slightly out of sequence, as it makes --http-proxy and --socks-proxy work using IPv6 to connect to the proxy (ASSERT(af==AF_INET) failure otherwise), and does not rely on changes introduced by 04/14 and 05/14. Patch has been applied to the master branch. commit 50

[Openvpn-devel] [PATCH] Remove fields from "ip -6 route show" output that distort results.

2013-11-24 Thread Gert Doering
"ip -6 route show" prints stuff like "rtt 38ms rttvar 38ms cwnd 10", which sometimes changes while an OpenVPN test is running, resulting in spurious failures in the "ifconfig/route must be restored identically after OpenVPN ends" test. Not all fields are there all the time, so use "sed" to get rid

Re: [Openvpn-devel] [PATCH] Remove fields from "ip -6 route show" output that distort results.

2013-11-24 Thread Arne Schwabe
Am 24.11.13 17:13, schrieb Gert Doering: > "ip -6 route show" prints stuff like "rtt 38ms rttvar 38ms cwnd 10", which > sometimes changes while an OpenVPN test is running, resulting in spurious > failures in the "ifconfig/route must be restored identically after > OpenVPN ends" test. Not all field

[Openvpn-devel] [PATCH applied] Re: Remove fields from "ip -6 route show" output that distort results.

2013-11-24 Thread Gert Doering
Patch has been applied to the master and release/2.3 branch, with a slightly changed commit message (to make clear that this is about t_client.sh, not about openvpn itself). commit 8c19087034cb1076874075b9e2896ea3f7be59cf (master) commit 8a553107046b5f214f869f936ba198535571e941 (release/2.3) Aut

[Openvpn-devel] [PATCH applied] Re: Fix assertion when SIGUSR1 is received while getaddrinfo is successful

2013-11-24 Thread Gert Doering
ACK. I can't easily reproduce this issue here (it's timing critical and you need a slow resolver to be able to "hit" that window), but I think the bug is clear enough - without the patch, the code will destroy "res", then decide to ignore the signal (= not go to "done") and then fall over ASSERT(r