Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-05 Thread Max . Muster
Hi Davide,   nice idea. But I think I found two small bugs: First, it won't compile in a config w/o ENABLE_CLIENT_CR defined (there is no "sc_info"). Second, if I'm not mistaken, name and password are not copied correctly: If # of charachters is (pos - prev), the last charakter is at [pos - pre

Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-05 Thread Max Muster
oops, just took my "debug" version of src/openvpn/ssl.c ... Of course output of string length and especially password in log file is not intended ;-) Joerg Original-Nachricht Betreff: Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass Von: max.mus...@kaffeeschluerfe

Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass

2013-10-05 Thread Max . Muster
and another problem: Configs without "auth-user-pass" will segfault, for in options_postprocess_verify_ce you do a streq(options->auth_user_pass_file, "stdin") without checking first, if options->auth_user_pass_file is not NULL. so here is fix number three for src/openvpn/misc.c (in fact, it