[Openvpn-devel] [PATCH 4/4] Remove unused function no_tap_ifconfig

2013-03-11 Thread Arne Schwabe
Signed-off-by: Arne Schwabe --- src/openvpn/tun.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 9912b07..a361233 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -300,16 +300,6 @@ warn_on_use_of_common_subnets (void) } /*

[Openvpn-devel] [PATCH 3/4] Move static prototype definition from header into c file

2013-03-11 Thread Arne Schwabe
--- src/openvpn/tun.c |2 ++ src/openvpn/tun.h |2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 4b0365d..9912b07 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -73,6 +73,8 @@ static void solaris_error_close (struct

[Openvpn-devel] [PATCH 1/4] Remove unused function xor

2013-03-11 Thread Arne Schwabe
The function name xor is also a reserved keyword in C++ Signed-off-by: Arne Schwabe --- src/openvpn/buffer.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index 5e11de0..7cae733 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buf

[Openvpn-devel] [PATCH 2/4] Use casts when assigning void* variables.

2013-03-11 Thread Arne Schwabe
Clang in c mode warns about these. In C++ mode these are forbidden. Signed-off-by: Arne Schwabe --- src/openvpn/base64.c |2 +- src/openvpn/buffer.c |6 +++--- src/openvpn/init.c|2 +- src/openvpn/list.c|2 +- src/openvpn/

[Openvpn-devel] [PATCH] Repair "tcp server queue overflow" brokenness, more fallout.

2013-03-11 Thread gert
From: Gert Doering Return value of mbuf_len() wrong - it's returning a length value, not a yes/no value - so when the queue length approached 65 (full!), it still only returned "1", leading to MBUF overflow later on. Change from "bool" to "int", misbehaviour gone... Signed-off-by: Gert Doering

Re: [Openvpn-devel] [PATCH] Repair "tcp server queue overflow" brokenness, more fallout.

2013-03-11 Thread Arne Schwabe
On 11.03.2013 21:10, g...@greenie.muc.de wrote: From: Gert Doering Return value of mbuf_len() wrong - it's returning a length value, not a yes/no value - so when the queue length approached 65 (full!), it still only returned "1", leading to MBUF overflow later on. Change from "bool" to "int",