Re: [Openvpn-devel] Fixing "passtos" on !Linux

2012-12-20 Thread David Sommerseth
On 19/12/12 22:26, Gert Doering wrote: > Hi, > > On Mon, Dec 17, 2012 at 11:03:55PM +0100, Jeremie Le Hen wrote: >> I thereby kindly ask you to bring this patch in the source tree. I >> don't know about your release procedure, but it would be really nice if >> it could hit the tree before 2.3 is

Re: [Openvpn-devel] coverity issue 2 - dead default / code cleanup in mtcp.c

2012-12-20 Thread David Sommerseth
On 14/12/12 19:18, Gert Doering wrote: > Hi, > > next one: mtcp.c, about line 470: > > unsigned int flags = MTP_NONE; > > if (TUN_OUT(c)) > flags |= MTP_TUN_OUT; > if (LINK_OUT(c)) > flags |= MTP_LINK_OUT; > > switch (flags) > { > case MTP_TUN_OUT|MTP_LINK_OUT: > cas

Re: [Openvpn-devel] Fixing "passtos" on !Linux

2012-12-20 Thread Gert Doering
Hi, On Wed, Dec 19, 2012 at 11:13:05PM +0100, Jeremie Le Hen wrote: > > so I'd propose to #ifdef it differently, patch appended. > > Your patch looks fine to me. I went that way because I grep'ed the > source for TARGET_ and saw similar occurences of what I did, though each > part contained more