[Openvpn-devel] [PATCH] support UTF-8 --client-config-dir

2012-10-29 Thread Heiko Hund
If a common name (or user name, when used in conjunction with --username-as-common-name) contains UTF-8 encoded characters their octets get replaced by underscores. This becomes problematic when user "Müller" and "Möller" need to have a CCD files and both would be receive options from the file "M__

[Openvpn-devel] [PATCH] fix display of plugin hook types

2012-10-29 Thread Heiko Hund
The OPENVPN_PLUGIN_ROUTE_PREDOWN hook was missing and displayed as "PLUGIN_???" in the log. OPENVPN_PLUGIN_ENABLE_PF was the only one that displayed the OPENVPN_ prefix. Signed-off-by: Heiko Hund --- src/openvpn/plugin.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

Re: [Openvpn-devel] [PATCH] fix display of plugin hook types

2012-10-29 Thread David Sommerseth
On 29/10/12 14:38, Heiko Hund wrote: > The OPENVPN_PLUGIN_ROUTE_PREDOWN hook was missing and displayed as > "PLUGIN_???" in the log. > > OPENVPN_PLUGIN_ENABLE_PF was the only one that displayed the > OPENVPN_ prefix. > > Signed-off-by: Heiko Hund > --- > src/openvpn/plugin.c |4 +++- > 1 fi

Re: [Openvpn-devel] [PATCH] support UTF-8 --client-config-dir

2012-10-29 Thread David Sommerseth
On 29/10/12 14:16, Heiko Hund wrote: > If a common name (or user name, when used in conjunction with > --username-as-common-name) contains UTF-8 encoded characters their > octets get replaced by underscores. This becomes problematic when > user "Müller" and "Möller" need to have a CCD files and bot

[Openvpn-devel] [PATCH] Remove the support for using system() when executing external programs or scripts

2012-10-29 Thread David Sommerseth
From: David Sommerseth This patch removes the support for the system() call, and enforces the usage of execve() on the *nix platform and CreateProcessW() on Windows. This is to enhance the overall security when calling external scripts. Using system() is prone to shell expansions, which may

Re: [Openvpn-devel] RFC - Usage of --script-security with the 'system' flag

2012-10-29 Thread David Sommerseth
On 17/10/12 11:19, David Sommerseth wrote: > > Hi all, > > I've been reviewing a bug reported to the v2.3 code base. We're in the > beta phase currently, and this is a bug I'd like to get fixed before > we're moving on further. The bug is related to the use of the 'system' > flag in --script