Re: [Openvpn-devel] [Version 4] Merge getaddr_multi and getaddr6 into one function

2012-09-02 Thread Gert Doering
Hi, On Tue, Aug 07, 2012 at 12:03:57PM +0200, Arne Schwabe wrote: > the getaddr6 and getaddr_mutli functions are duplicates of each other. Since > we always require getaddrinfo to be present both function are merge into one > openvpn_getaddrinfo. > > This functions also returns a standard struc

[Openvpn-devel] [PATCH] Simplify print_sockaddr_ex function, merge duplicate ipv4/ipv6 logic

2012-09-02 Thread Arne Schwabe
Signed-off-by: Arne Schwabe --- src/openvpn/socket.c | 89 ++ 1 file changed, 39 insertions(+), 50 deletions(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index a34e78c..5b2bb9d 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/so

Re: [Openvpn-devel] [PATCH] Simplify print_sockaddr_ex function, merge duplicate ipv4/ipv6 logic

2012-09-02 Thread Gert Doering
Hi, (note that this is v2 of the patch with a change to getnameinfo()'s 2nd field, passing ->addr.sa.sa_len now) ACK, tested and reviewed. The tabbing is left for David to repair :-) gert On Sun, Sep 02, 2012 at 09:15:33PM +0200, Arne Schwabe wrote: > Signed-off-by: Arne Schwabe > --- > src

Re: [Openvpn-devel] [Version 4] Merge getaddr_multi and getaddr6 into one function

2012-09-02 Thread David Sommerseth
On 07/08/12 12:03, Arne Schwabe wrote: > the getaddr6 and getaddr_mutli functions are duplicates of each other. Since > we always require getaddrinfo to be present both function are merge into one > openvpn_getaddrinfo. > > This functions also returns a standard struct addrinfo* so our resolve

Re: [Openvpn-devel] [PATCH] Document the inlining of files in openvpn and document key-direction

2012-09-02 Thread David Sommerseth
On 23/08/12 23:21, Arne Schwabe wrote: > This patch documents the usage of inline files in OpenVPN. Hackish ways of > inline files are deliberately left out. For tls-auth and > secret the key-direction option is right way of specifying the direction and > not by using two tls-auth/secret lines wh

Re: [Openvpn-devel] [PATCH] remove stale _openssl_get_subject() prototype

2012-09-02 Thread David Sommerseth
On 17/08/12 11:52, Heiko Hund wrote: > The _openssl_get_subject() function was removed in commit > 00b973f8af85c3ea8fa3cef80eec55e8dc139b27. The functionality > moved to x509_get_subject(). > > Signed-off-by: Heiko Hund > --- > src/openvpn/ssl_verify_openssl.h |2 -- > 1 file changed, 2 dele

Re: [Openvpn-devel] [PATCH 1/2] Put actual OpenVPN command line on top of corresponding log file.

2012-09-02 Thread David Sommerseth
On 16/08/12 20:31, Gert Doering wrote: > This is useful if a test fails, and the tester wants to run the very > same OpenVPN call with the very same arguments interactively to > pinpoint and fix the problem. > > Signed-off-by: Gert Doering > --- > tests/t_client.sh.in |3 ++- > 1 files chang

Re: [Openvpn-devel] [PATCH 2/2] Reduce --version string detail about IPv6 to just "[IPv6]".

2012-09-02 Thread David Sommerseth
On 16/08/12 20:31, Gert Doering wrote: > For 2.3 release, we do not need to have more details, as there is no > separate patch set anymore, and both IPv6 transport and IPv6 payload > (PF_INET6) have been fully integrated. > > Signed-off-by: Gert Doering > --- > src/openvpn/options.c |3 +-- >

Re: [Openvpn-devel] [PATCH] remove unused flag SSLF_NO_NAME_REMAPPING

2012-09-02 Thread David Sommerseth
On 17/08/12 11:51, Heiko Hund wrote: > The flag was used with the --no-name-remapping option that was removed > in commit 5e86fd93779482b90a191f929edebe414cd78a4f. > > Signed-off-by: Heiko Hund > --- > src/openvpn/ssl_common.h |1 - > 1 file changed, 1 deletion(-) Applied to master. commit

Re: [Openvpn-devel] [PATCH] Keep pre-existing tun/tap devices around on *BSD

2012-09-02 Thread David Sommerseth
On 16/08/12 20:09, Gert Doering wrote: > This amends commit 62c613d46dc49 to check whether a named tun/tap > device ("--dev tunX" instead of "--dev tun") exists before OpenVPN > started - if yes, keep around at program end. If no, destroy. > > Also has a spelling fix, and changes clear_tuntap() t

Re: [Openvpn-devel] [PATCH] Document --management-client and --management-signal a bit better

2012-09-02 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/08/12 19:31, Arne Schwabe wrote: > Signed-off-by: Arne Schwabe --- doc/openvpn.8 | > 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Applied to master. commit c447b4265cd3fae308dd5798081d42f87ae89d91 Author: Arne Schwabe List-Po