Some plugins want to add messages to the openvpn log file. The
plugin_log() API provides a way for them to do so.
Signed-off-by: Heiko Hund
---
This is the first variant of PATCH 2/2 that deals with the fact that
the original plugin_log() approach was not working on Windows.
It uses an inline f
Some plugins want to add messages to the openvpn log file. The
plugin_log() API provides a way for them to do so.
Signed-off-by: Heiko Hund
---
This is the second variant of PATCH 2/2 that deals with the fact that
the original plugin_log() approach was not working on Windows.
It passes the func
This is how it should be done, no games with symbols and linkage.
Please add printf style pragmas to the function.
On Thu, Aug 2, 2012 at 12:53 PM, Heiko Hund wrote:
> Some plugins want to add messages to the openvpn log file. The
> plugin_log() API provides a way for them to do so.
>
> Signed-o
And export vprintf variant as well, to allow wrapper.
On Thu, Aug 2, 2012 at 1:02 PM, Alon Bar-Lev wrote:
> This is how it should be done, no games with symbols and linkage.
>
> Please add printf style pragmas to the function.
>
> On Thu, Aug 2, 2012 at 12:53 PM, Heiko Hund wrote:
>> Some plugin
Some plugins want to add messages to the openvpn log file. The
plugin_log() and plugin_vlog() APIs provide ways for them to do so.
Signed-off-by: Heiko Hund
---
Changes since PATCH 2/2 v2.2:
* add plugin_vlog() API which takes a va_list
* pass struct openvpn_plugin_callbacks to open_v3 plug
What about the printf style pragma?
It is very convenience to find format issue at compile times.
On Thu, Aug 2, 2012 at 4:03 PM, Heiko Hund wrote:
> Some plugins want to add messages to the openvpn log file. The
> plugin_log() and plugin_vlog() APIs provide ways for them to do so.
>
> Signed-off
Signed-off-by: Arne Schwabe
---
src/openvpn/manage.c |4 ++--
src/openvpn/socket.c | 53 +++---
src/openvpn/socket.h |2 +-
3 files changed, 10 insertions(+), 49 deletions(-)
diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 3ef1
Warn if both options are used at the same time.
Signed-off-by: Arne Schwabe
---
src/openvpn/options.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 9f4ddbb..39dceb8 100644
--- a/src/openvpn/options.c
+
Hi,
On Thu, Aug 02, 2012 at 03:36:59PM +0200, Arne Schwabe wrote:
> Signed-off-by: Arne Schwabe
> ---
> src/openvpn/manage.c |4 ++--
> src/openvpn/socket.c | 53
> +++---
> src/openvpn/socket.h |2 +-
> 3 files changed, 10 insertions(+), 49
Hi,
On Thu, Aug 02, 2012 at 03:37:48PM +0200, Arne Schwabe wrote:
> Warn if both options are used at the same time.
>
> Signed-off-by: Arne Schwabe
ACK on v2 of 1/4. Same effect, less complications.
gert
--
USENET is *not* the non-clickable part of WWW!
Some plugins want to add messages to the openvpn log file. The
plugin_log() and plugin_vlog() APIs provide ways for them to do so.
OPENVPN_PLUGINv3_STRUCTVER is not incremented as the v3 plugin API
is new in 2.3 and this is merged during alpha phase.
Signed-off-by: Heiko Hund
---
Changes since
Thanks, although I think the extra macro is not required.
Last thing I see is that you need to #include as va_list is used.
And last style comment, I don't think use of enum for bit fields is
common, better to simply #define the constants.
On Thu, Aug 2, 2012 at 6:20 PM, Heiko Hund wrote:
> Som
12 matches
Mail list logo
