Re: [Openvpn-devel] [RFC] give plugins a method to pass log lines to openvpn

2012-07-31 Thread Heiko Hund
Hi David. Thanks for the feedback. On Monday 30 July 2012 19:06:02 David Sommerseth wrote: > My immediate thought/question is: Why can we not export msg() to > plug-ins? Or at least provide something more like a functional > oriented API to work with? Actually that's my favored way as well. I j

Re: [Openvpn-devel] [RFC] give plugins a method to pass log lines to openvpn

2012-07-31 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/07/12 13:31, Heiko Hund wrote: >> But it should also prefix these log lines as coming from a >> plug-in (preferably with the plug-in name included)... > > I don't think enforcing something like this makes much sense, as > evil plugins, trying to

[Openvpn-devel] [PATCH] add plugin_log() API to write to openvpn log

2012-07-31 Thread Heiko Hund
Some plugins want to add messages to the openvpn log file. The plugin_log() API provides a way for them to do so. Signed-off-by: Heiko Hund --- include/openvpn-plugin.h | 20 src/openvpn/error.c | 11 --- src/openvpn/error.h |2 ++ src/openvpn/plugi

Re: [Openvpn-devel] [RFC] give plugins a method to pass log lines to openvpn

2012-07-31 Thread Heiko Hund
On Tuesday 31 July 2012 14:14:10 David Sommerseth wrote: > - From another point of view, an evil plug-in would have to know/figure > out the address to x_msg() ... so that would require a bit more work, > at least to work against different distro/compiler/linker > combinations, as it's not given th