Re: [Openvpn-devel] [PATCH] Fix --management-external-key in 2.3alpha

2012-06-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/06/12 23:21, Arne Schwabe wrote: >> But ... is it expected to pass --key if you use >> --management-external-key? I probably don't know enough about >> this --management-external-key feature, so I might be wrong. > > No. --key is not passed but

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-06-29 Thread David Sommerseth
On 24/03/12 21:31, Alon Bar-Lev wrote: > Discussed at [1]. > > Use wmain under windows, drop the custom parsing and shell32 linkage. > > There is no need for gc magic as this allocation is static. > > [1] http://permalink.gmane.org/gmane.network.openvpn.devel/5433 > > Signed-off-by: Alon Bar-Le

Re: [Openvpn-devel] [PATCH] build: msvc: chdir with change drive to script location

2012-06-29 Thread Samuli Seppänen
I tested building with "openvpn-build\msvc" with this patch applied, and it still worked. I don't see any reason not to apply this, so it's an ACK. The "cd /d %0\.." magic is very interesting... "cd %0\.." seems to work exactly the same: both switch to the directory where msvc-build.bat is located

Re: [Openvpn-devel] [PATCH] build: msvc: chdir with change drive to script location

2012-06-29 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/04/12 20:51, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > msvc-build.bat |1 + msvc-dev.bat |2 +- msvc-env.bat | > 2 -- 3 files changed, 2 insertions(+), 3 deletions(-) > Applied to master. commit 6d2b65ad322e587efaf43c

Re: [Openvpn-devel] [PATCH] Fix --management-external-key in 2.3alpha

2012-06-29 Thread Arne Schwabe
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 29.06.12 09:49, schrieb David Sommerseth: > On 28/06/12 23:21, Arne Schwabe wrote: > >> But ... is it expected to pass --key if you use > >> --management-external-key? I probably don't know enough about > >> this --management-external-key feature,