Re: [Openvpn-devel] [PATCH 1/6] Only use tmpdir if tmp_dir is really used.

2012-06-19 Thread Gert Doering
Hi, On Mon, Jun 18, 2012 at 08:39:04PM +0200, Arne Schwabe wrote: > This fixes starting openvpn compiled as client only version of systems that > have no /tmp (Android). --tmp-dir could only be set if P2MP_SERVER has been > enabled too. ACK - as previously discussed on the list and IRC. gert -

Re: [Openvpn-devel] [PATCH 2/6] Completely remove ancient IANA port warning.

2012-06-19 Thread Gert Doering
Hi, On Mon, Jun 18, 2012 at 08:39:05PM +0200, Arne Schwabe wrote: > @@ -2462,12 +2462,6 @@ do_option_warnings (struct context *c) > { >const struct options *o = &c->options; > > -#if 1 /* JYFIXME -- port warning */ > - if (!o->ce.port_option_used && (o->ce.local_port == OPENVPN_PORT && >

Re: [Openvpn-devel] [PATCH 3/6] Remove ENABLE_INLINE_FILES conditionals, this code is always enabled and removing the #ifdef make the code a little bit clearer

2012-06-19 Thread Gert Doering
Hi, On Mon, Jun 18, 2012 at 08:39:06PM +0200, Arne Schwabe wrote: > @@ -95,9 +95,7 @@ typedef unsigned long ptr_type; > * A sort of pseudo-filename for data provided inline within > * the configuration file. > */ > -#if ENABLE_INLINE_FILES > #define INLINE_FILE_TAG "[[INLINE]]" > -#endif I

Re: [Openvpn-devel] [PATCH 4/6] Remove ENABLE_CONNECTIONS ifdefs, connections were always on for a long time. Not that ENABLE_MAMAGEMENT_REMOTE was only depending on ENABLE_CONNECTIONS and is removed

2012-06-19 Thread Gert Doering
Hi, On Mon, Jun 18, 2012 at 08:39:07PM +0200, Arne Schwabe wrote: > #endif > > -#if MANAGEMENT_QUERY_REMOTE > - > static bool [..] > init_connection_list (struct context *c) > { > -#ifdef ENABLE_CONNECTION >struct connection_list *l = c->options.connection_list; >if (l) [..] Same as

[Openvpn-devel] key exchange using a different physical channel

2012-06-19 Thread Igor Lopez Orbe
Hello everyone! I would like to know if is there any "simple" way to do the key exchange using our own method (which will use different physical channel) in order to use the TLS control channel. I have taken a look to the code of OpenVPN and the possible option i found is to create key_method_3_wr