[Openvpn-devel] Topics for today's meeting

Hi, We're having an IRC meeting today, starting at 18:00 UTC on #openvpn-de...@irc.freenode.net. Current topic list is here: If you have any other things you'd like to bring up, respond to this mail, send me mail privately or add the

[Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

These days it is highly unlikely that OpenVPN will be built in a non-IPv6 capable Linux environment. So remove compile-time related macros identifying that. This also solves an issue which was introduced in commit 51bd56f46f55177cf0f8b where HAVE_TUN_PI and HAVE_IPHDR is no longer detected. As t

Re: [Openvpn-devel] [PATCH] cleanup: remove C++ comments

Hi Alon, 2012/4/7 Alon Bar-Lev : > Signed-off-by: Alon Bar-Lev > --- >  src/openvpnserv/openvpnserv.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/openvpnserv/openvpnserv.c b/src/openvpnserv/openvpnserv.c > index a9a9441..56f5a02 100755 > --- a/src/openvp

Re: [Openvpn-devel] [PATCH] cleanup: plugin: support C++ plugin

Hi Alon, 2012/4/7 Alon Bar-Lev : > Signed-off-by: Alon Bar-Lev > --- >  include/openvpn-plugin.h |    8 >  1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/include/openvpn-plugin.h b/include/openvpn-plugin.h > index f82f61f..1c80eec 100644 > --- a/include/openvpn-plugin.

Re: [Openvpn-devel] [PATCH] cleanup: add .gitattributes to control eol style explicitly

Hi Alon, 2012/4/2 Alon Bar-Lev : > Having the text auto detection is a risk, as the detection may detect > text files that are not text and vise versa. > > Having global setting will create confusion and differentiate between > users. So this patch also move this to local repository. IMHO, this i

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi, On Thu, Apr 26, 2012 at 01:51:25PM +0200, David Sommerseth wrote: > These days it is highly unlikely that OpenVPN will be built in a non-IPv6 > capable Linux environment. So remove compile-time related macros identifying > that. > > This also solves an issue which was introduced in commit 51

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi David, 2012/4/26 David Sommerseth : > These days it is highly unlikely that OpenVPN will be built in a non-IPv6 > capable Linux environment. Agreed. > This also solves an issue which was introduced in commit 51bd56f46f55177cf0f8b > where HAVE_TUN_PI and HAVE_IPHDR is no longer detected.  As t

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi, On Thu, Apr 26, 2012 at 03:11:54PM +0200, Fabian Knittel wrote: > Gert appears to be happy, so I'm happy, but I don't quite understand > what you're saying here. What part broke? HAVE_TUN_PI and HAVE_IPHDR > aren't always detected although they should be? Or the failed > detection affects non-

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

I plan to add --enable-ipv6/--disable-ipv6 to explicit support ipv6. This is part of syshead fixups. Cleaning a lot of code of autoconf auto detection of socket functions. On Thu, Apr 26, 2012 at 2:51 PM, David Sommerseth wrote: > These days it is highly unlikely that OpenVPN will be built in a n

Re: [Openvpn-devel] [PATCH] cleanup: remove C++ comments

On Thu, Apr 26, 2012 at 3:33 PM, Fabian Knittel wrote: > Hi Alon, > > 2012/4/7 Alon Bar-Lev : >> Signed-off-by: Alon Bar-Lev >> --- >>  src/openvpnserv/openvpnserv.c |    6 +++--- >>  1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/openvpnserv/openvpnserv.c b/src/openvpnse

Re: [Openvpn-devel] [PATCH] cleanup: add .gitattributes to control eol style explicitly

On Thu, Apr 26, 2012 at 3:45 PM, Fabian Knittel wrote: > Hi Alon, > > 2012/4/2 Alon Bar-Lev : >> Having the text auto detection is a risk, as the detection may detect >> text files that are not text and vise versa. >> >> Having global setting will create confusion and differentiate between >> user

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi, On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote: > I plan to add --enable-ipv6/--disable-ipv6 to explicit support ipv6. NAK. We considered this, and this will add a shitload of #ifdefs which will make maintenance of the code a lot harder. (We actually *removed* all the #ifdefs

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/04/12 19:24, Gert Doering wrote: > Hi, > > On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote: >> I plan to add --enable-ipv6/--disable-ipv6 to explicit support >> ipv6. > > NAK. > > We considered this, and this will add a shitload

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

On Thu, Apr 26, 2012 at 8:32 PM, David Sommerseth wrote: > On 26/04/12 19:24, Gert Doering wrote: >> Hi, >> >> On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote: >>> I plan to add --enable-ipv6/--disable-ipv6 to explicit support >>> ipv6. >> >> NAK. >> >> We considered this, and this wi

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

On Thu, Apr 26, 2012 at 8:35 PM, Alon Bar-Lev wrote: > On Thu, Apr 26, 2012 at 8:32 PM, David Sommerseth > wrote: >> On 26/04/12 19:24, Gert Doering wrote: >>> Hi, >>> >>> On Thu, Apr 26, 2012 at 07:03:40PM +0300, Alon Bar-Lev wrote: I plan to add --enable-ipv6/--disable-ipv6 to explicit sup

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

On Thu, Apr 26, 2012 at 8:56 PM, Fabian Knittel wrote: > Hi Alon, > > 2012/4/26 Alon Bar-Lev : >> At embedded system and several distros like Gentoo, the ipv6 should be >> made enable/disabled, just like any other project. >> It is the same #ifdef as we already have these in code. >> Even in 2012

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi, On Thu, Apr 26, 2012 at 08:35:54PM +0300, Alon Bar-Lev wrote: > At embedded system and several distros like Gentoo, the ipv6 should be > made enable/disabled, just like any other project. > It is the same #ifdef as we already have these in code. > Even in 2012 kernels can be compiled without i

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi Alon, 2012/4/26 Alon Bar-Lev : > At embedded system and several distros like Gentoo, the ipv6 should be > made enable/disabled, just like any other project. > It is the same #ifdef as we already have these in code. > Even in 2012 kernels can be compiled without ipv6. If embedded systems really

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

On Thu, Apr 26, 2012 at 9:01 PM, Gert Doering wrote: > Hi, > > On Thu, Apr 26, 2012 at 08:35:54PM +0300, Alon Bar-Lev wrote: >> At embedded system and several distros like Gentoo, the ipv6 should be >> made enable/disabled, just like any other project. >> It is the same #ifdef as we already have t

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi, On Thu, Apr 26, 2012 at 09:06:19PM +0300, Alon Bar-Lev wrote: > Right, the ipv6 was added indeed differently, without this conditionals. You missed the part that JJO's IPv6 code *was* added with conditionals, and that caused problems. We *removed* the conditionals, and the resulting code is

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

On Thu, Apr 26, 2012 at 9:17 PM, Gert Doering wrote: > Hi, > > On Thu, Apr 26, 2012 at 09:06:19PM +0300, Alon Bar-Lev wrote: >> Right, the ipv6 was added indeed differently, without this conditionals. > > You missed the part that JJO's IPv6 code *was* added with conditionals, > and that caused pro

Re: [Openvpn-devel] [PATCH] Presume that Linux is always IPv6 capable at build time

Hi, On Thu, Apr 26, 2012 at 09:20:14PM +0300, Alon Bar-Lev wrote: > > We want to *reduce* the number of #ifdef in the code. > > Not necessary, I would like to make it compatible with other well > behaved projects out there. You are young, and will learn. "Well behaved projects" are not those th

Re: [Openvpn-devel] [PATCH] cleanup: add .gitattributes to control eol style explicitly

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/04/12 13:37, Alon Bar-Lev wrote: > Having the text auto detection is a risk, as the detection may > detect text files that are not text and vise versa. > > Having global setting will create confusion and differentiate > between users. So this pa

Re: [Openvpn-devel] [PATCH] build: fix some statement left from conversion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/04/12 19:39, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > configure.ac | 12 ++-- 1 files changed, 6 insertions(+), > 6 deletions(-) ACK. Applied to master on -testing and -stable. commit 7c0a2b5f2b4409c8c05c2356f91ee9ae2

Re: [Openvpn-devel] [PATCH] build: properly detect netinet/ip.h structs

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/04/12 21:22, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > configure.ac |3 +++ 1 files changed, 3 insertions(+), 0 > deletions(-) ACK. Applied to master on -testing and -stable trees. commit 4025a59575a9a90cb96fde01eba8db3c1cab

Re: [Openvpn-devel] [PATCH] Ensure sys/un.h autoconf detection includes sys/socket.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/04/12 08:50, Adriaan de Jong wrote: > This is required to build an Android binary. > > Signed-off-by: Adriaan de Jong --- configure.ac > |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Applied to master on -testing and -stable tre

Re: [Openvpn-devel] [PATCH] cleanup: remove C++ comments

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/04/12 19:42, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > src/openvpnserv/openvpnserv.c |6 +++--- 1 files changed, 3 > insertions(+), 3 deletions(-) Applied to master on -testing and -stable trees. commit a9da960dc178a11bdb9de2

Re: [Openvpn-devel] [PATCH] cleanup: plugin: support C++ plugin

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/04/12 19:40, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > include/openvpn-plugin.h |8 1 files changed, 8 > insertions(+), 0 deletions(-) ACK and applied to master on -testing and stable trees. commit 13663f206dbd036add

Re: [Openvpn-devel] [PATCH] build: properly detect TUNSETPERSIST

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/04/12 21:21, Alon Bar-Lev wrote: > Do not rely on system symbol throught sources but on autoconf > detection. > > Signed-off-by: Alon Bar-Lev --- > configure.ac | 10 ++ src/openvpn/init.c| > 2 +- src/openvpn/options.c |

[Openvpn-devel] [PATCH] build: use stdbool.h if available

If stdbool.h is available use it, otherwise create emulation. basic.h defines a type 'bool' that conflicts with the altivec keyword bool which has to be fixed upstream, see bugs[1][2]. [1] https://bugs.gentoo.org/show_bug.cgi?id=293840 [2] https://bugs.gentoo.org/show_bug.cgi?id=297854 Signed-of

Re: [Openvpn-devel] [PATCH] build: use stdbool.h if available

On Fri, Apr 27, 2012 at 1:27 AM, Alon Bar-Lev wrote: > If stdbool.h is available use it, otherwise create emulation. > > basic.h defines a type 'bool' that conflicts with > the altivec keyword bool which has to be fixed upstream, see > bugs[1][2]. > > [1] https://bugs.gentoo.org/show_bug.cgi?id=29

[Openvpn-devel] tap-windows - release

Hello Samuli, The tap-windows project unlikely to be changed, I think we should release it. I already created public repository[1], completed the separate build, signing and packaging. All we need is a signed build. Something like: set CODESIGN_PKCS12= set CODESIGN_PASS=>password> configure bui