[Openvpn-devel] [PATCH] crash: packet_id_debug_print: sl may be null

2012-04-08 Thread Alon Bar-Lev
Program received signal SIGSEGV, Segmentation fault. packet_id_debug_print (msglevel=1174405255, p=0xa36bd0718, pin=0x3de5feec1b0, message=0xa330dde80 "PID_TEST", value=0) at ../../../src/openvpn/packet_id.c:504 504 for (i = 0; i < sl->x_size; ++i) (gdb) print sl $2 = (const struct seq_list

[Openvpn-devel] [RFC] tun cleanups

2012-04-08 Thread Alon Bar-Lev
Hello, I started to work on the syshead cleanups, then found my-self evaluating the tun.c complexity, and prioritize it. So basically we have two branches: https://github.com/alonbl/openvpn/compare/master...syshead https://github.com/alonbl/openvpn/compare/master...tun The tun branch is based on

Re: [Openvpn-devel] [RFC] tun cleanups

2012-04-08 Thread Gert Doering
Hi, On Sun, Apr 08, 2012 at 01:43:12PM +0300, Alon Bar-Lev wrote: > What I am asking is for people that wishes to work with me on this > (not the ACK/NACK approach) to allow perfecting this *BEFORE* merge. I would actually ask for "no more cleanup changes to tun.c before 2.3" - I have cleaned up

Re: [Openvpn-devel] [RFC] tun cleanups

2012-04-08 Thread Alon Bar-Lev
On Sun, Apr 8, 2012 at 1:56 PM, Gert Doering wrote: > Hi, > > On Sun, Apr 08, 2012 at 01:43:12PM +0300, Alon Bar-Lev wrote: >> What I am asking is for people that wishes to work with me on this >> (not the ACK/NACK approach) to allow perfecting this *BEFORE* merge. > > I would actually ask for "no

Re: [Openvpn-devel] [RFC] tun cleanups

2012-04-08 Thread Gert Doering
Hi, On Sun, Apr 08, 2012 at 02:01:55PM +0300, Alon Bar-Lev wrote: > On Sun, Apr 8, 2012 at 1:56 PM, Gert Doering wrote: > > On Sun, Apr 08, 2012 at 01:43:12PM +0300, Alon Bar-Lev wrote: > >> What I am asking is for people that wishes to work with me on this > >> (not the ACK/NACK approach) to all

[Openvpn-devel] [PATCH] build: properly detect TUNSETPERSIST

2012-04-08 Thread Alon Bar-Lev
Do not rely on system symbol throught sources but on autoconf detection. Signed-off-by: Alon Bar-Lev --- configure.ac | 10 ++ src/openvpn/init.c|2 +- src/openvpn/options.c |8 src/openvpn/tun.c |4 ++-- 4 files changed, 17 insertions(+), 7 deleti

[Openvpn-devel] [PATCH] build: properly detect netinet/ip.h structs

2012-04-08 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev --- configure.ac |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index d40f7dc..773fa4b 100644 --- a/configure.ac +++ b/configure.ac @@ -396,6 +396,9 @@ SOCKET_INCLUDES=" #ifdef HAVE_NETINET_IN_SYSTM_H #include