Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

2012-03-31 Thread Jonathan K. Bullard
On Wed, Mar 28, 2012 at 2:11 PM, David Sommerseth < openvpn.l...@topphemmelig.net> wrote: > > Attached is a heavily revised version of my original patch. It uses > > argv_printf() to __check__ an option's commands, so it accepts exactly > > the same input as the parts of OpenVPN that __use__ the

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

2012-03-31 Thread Gert Doering
Hi, On Sat, Mar 31, 2012 at 07:47:34AM -0400, Jonathan K. Bullard wrote: > Thanks for this suggestion, David, but I believe it is better to create a > separate routine for this: > >1. The input is not a path, but a "command". A "command" is processed >(single- and double-quote and backsla

Re: [Openvpn-devel] [PATCH 3/4] cleanup: avoid using ~0 - netmask

2012-03-31 Thread Gert Doering
Hi, On Thu, Mar 29, 2012 at 11:16:41AM +0200, Alon Bar-Lev wrote: > Use IPV4_NETMASK_HOST constant. > > Signed-off-by: Alon Bar-Lev ACK on this one, to start with. Thanks. The others I'm just looking into, but need to read a bit more code around to see whether I fully understand what that cod