Hi all,
We're starting to get close to first OpenVPN 2.3 alpha release. Here's a
new Windows snapshot installer based on latest "master" with one minor
modification[1]:
<http://build.openvpn.net/downloads/snapshots/openvpn-2.x-master-20111202-wo-startup-test-install.exe>
Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds some extra
checks on configured files and directories. This required use of
the dirname() function. Unfortunately, this function is not available
on Windows.
This function reimplements the POSIX variant of dirname(), using the
framework alread
Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds extra file and
directory checks at startup. However, this patch makes use of some
features not directly available in Windows.
This patch avoids #include on Windows and provides a
wrapper for the needed access() function.
Signed-off-by: David
Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds extra file and
directory checks at startup. However, this patch makes use of some
features not directly available in Windows.
This patch avoids #include on Windows and provides a
wrapper for the needed access() function. The wrapper function
Why not:
#ifdef WIN32
#define access _access
#endif
On Fri, Dec 2, 2011 at 2:17 PM, David Sommerseth wrote:
> Commit 0f2bc0dd92f43c91e33bba8a66b06b98f281efc1 adds extra file and
> directory checks at startup. However, this patch makes use of some
> features not directly available in Windows.
>
I think the whole code should be more autoconf depended.
Autoconf can detect if POSIX version is available and if not, code can
provide alternative.
No need for the openvpn_ functions and wrappers.
On Fri, Dec 2, 2011 at 1:02 PM, David Sommerseth wrote:
>
> Commit 0f2bc0dd92f43c91e33bba8a66b06b98
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/12/11 13:28, Alon Bar-Lev wrote:
> I think the whole code should be more autoconf depended. Autoconf can
> detect if POSIX version is available and if not, code can provide
> alternative. No need for the openvpn_ functions and wrappers.
Fair eno
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/12/11 13:25, Alon Bar-Lev wrote:
> Why not: #ifdef WIN32 #define access _access #endif
No particular reason, other than the approach with static inline
functions seems more cleaner in my eyes. The first version of this patch
declared an access(
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
We've had a very strict patch review regime since we moved over to git.
We see that this regime does work, but it can take a very long time
before patches are reviewed and ACKed for inclusion. This long delay is
something we are less happy about
On Fri, Dec 2, 2011 at 2:38 PM, David Sommerseth
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 02/12/11 13:28, Alon Bar-Lev wrote:
>> I think the whole code should be more autoconf depended. Autoconf can
>> detect if POSIX version is available and if not, code can provide
>> alte
"Alon Bar-Lev" wrote:
Why not:
#ifdef WIN32
#define access _access
#endif
We should write "#ifndef _MSC_VER". MingW's access() handles
X_OK correctly. From MingW's :
#ifdef __USE_MINGW_ACCESS
/* Old versions of MSVCRT access() just ignored X_OK, while the version
shipped with Vista, re
If using mingw there is no reason why not use autoconf/automake.
If using MSVC you know what you get.
This is how I see it:
config-msvc.h
#define HAVE_ACCESS 1
#define access _access
compat.h
#ifndef HAVE_ACCESS
int access(...);
#endif
compat.c
#ifndef HAVE_ACCESS
int access(...) {
}
#endif
At
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/12/11 13:45, Alon Bar-Lev wrote:
> On Fri, Dec 2, 2011 at 2:38 PM, David Sommerseth
> wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>>
>> On 02/12/11 13:28, Alon Bar-Lev wrote:
>>> I think the whole code should be more autoconf depen
This argument allows the keyword 'stdin' to indicate that the input
is to be read from the stdin. Don't check for file existence if the
file name is set to 'stdin'
Signed-off-by: David Sommerseth
---
options.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/options.
14 matches
Mail list logo
