Re: [Openvpn-devel] [PATCH] Changed snprintf to _snprintf in service-win32/openvpnserv.c

Am 05.01.2011 14:21, schrieb Samuli Seppänen: > This fixes a generic Windows/VC++ issue: > > > > Does this change affect the automake/gcc-based Windows builds? NAK. Do not mess with the names

[Openvpn-devel] [PATCH 2/2] Hook auth-pam and down-root to the build.

This includes autoconf checks so we only build auth-pam on systems that have security/pam_appl.h --- Makefile.am | 17 + configure.ac | 10 ++ m4/README |3 +++ plugin/README | 13 +++-- 4 files changed, 37 insertions(+), 6 deletions(-) create mode

[Openvpn-devel] [PATCH 1/2] Cleanup: move AC_GNU_SOURCE to quench autotools warnings.

--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index e30f990..e1ca65e 100644 --- a/configure.ac +++ b/configure.ac @@ -32,6 +32,7 @@ AC_CONFIG_SRCDIR(syshead.h) dnl Guess host type. AC_CANONICAL_HOST +AC_GNU_SOURCE AM_INIT

[Openvpn-devel] beta2.2: automake support for plugin build

Greetings, this is the beta2.2 patch pair for hooking the auth-pam and down-root plugins to the build. The bugfix2.1 patch pair has been sent earlier. Looking for review, ACK and NAK. Best regards Matthias

[Openvpn-devel] [PATCH 1/2] Cleanup: move AC_GNU_SOURCE to quench autotools warnings.

--- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 4777108..529abd3 100644 --- a/configure.ac +++ b/configure.ac @@ -32,6 +32,7 @@ AC_CONFIG_SRCDIR(syshead.h) dnl Guess host type. AC_CANONICAL_HOST +AC_GNU_SOURCE AM_INIT

[Openvpn-devel] [PATCH 2/2] Hook auth-pam and down-root to the build.

This includes autoconf checks so we only build auth-pam on systems that have security/pam_appl.h --- Makefile.am | 16 configure.ac | 10 ++ m4/README |3 +++ plugin/README | 13 +++-- 4 files changed, 36 insertions(+), 6 deletions(-) create mode

[Openvpn-devel] bugfix2.1: automake support for plugin build

Greetings, following up the "[OpenVPN 2.1.4 BUG]: hard-coded values in Makefiles for down-root and auth-pam plugins prevent cross compilation" bug, I am providing patches for review and test in cross-compilation environments. I have tested these on native compiles with Ubuntu Linux 10.10 32-bit,

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

This is the patch series for the bugfix2.1 branch. I will send a separate patch pair for beta 2.2 soon. Looking for feedback, review, and ACK or NAK :-) I take it that these patches could be applied to the 2.1.4 version tree, right? If so, I would be able to test this tonight (including c

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

I suppose you need to modify the .spec file to make sure you're running autoreconf twice up front (or libtoolize, aclocal, autoconf, automake, possibly autoheader). Note you'll want to remove the .la files from the destdir, and list the .so files in the %files section, /usr/lib/openvpn/*.so mig

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

Am 06.01.2011 21:42, schrieb Mr Dash Four: > >> I suppose you need to modify the .spec file to make sure you're running >> autoreconf twice up front (or libtoolize, aclocal, autoconf, automake, >> possibly autoheader). >> >> Note you'll want to remove the .la files from the destdir, and list the >

Re: [Openvpn-devel] beta2.2: automake support for plugin build

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/01/11 18:13, Matthias Andree wrote: | Greetings, | | this is the beta2.2 patch pair for hooking the auth-pam and down-root | plugins to the build. | | The bugfix2.1 patch pair has been sent earlier. | | Looking for review, ACK and NAK. | Hi Mat

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

This has gone wrong. The plugins should be built from the top-level directory instead (see below how it works for me), with the regular "make" that also builds openvpn, so the "for plugin in ... make -C $plugin ..." is no longer needed for these two guys. "make install" should load the materia

[Openvpn-devel] [PATCH v2 5/4] Separate the general plug-in version constant and v3 plug-in structs version

After a review of the second round of the the v3 plug-in implementation, it was decided to use a separate constant defining the version of the structs used for argument and return value passing, instead of OPENVPN_PLUGIN_VERSION. To not make it too complex, this patch uses a shared version constan

Re: [Openvpn-devel] beta2.2: automake support for plugin build

Am 06.01.2011 22:50, schrieb David Sommerseth: > On 06/01/11 18:13, Matthias Andree wrote: > | Greetings, > | > | this is the beta2.2 patch pair for hooking the auth-pam and down-root > | plugins to the build. > | > | The bugfix2.1 patch pair has been sent earlier. > | > | Looking for review, ACK a

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

Am 06.01.2011 23:07, schrieb Mr Dash Four: > >> This has gone wrong. The plugins should be built from the top-level >> directory instead (see below how it works for me), with the regular >> "make" that also builds openvpn, so the "for plugin in ... make -C >> $plugin ..." is no longer needed for

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

This has gone wrong. The plugins should be built from the top-level directory instead (see below how it works for me), with the regular "make" that also builds openvpn, so the "for plugin in ... make -C $plugin ..." is no longer needed for these two guys. I just removed the loop to see if it

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

Am 06.01.2011 23:59, schrieb Mr Dash Four: > >> This has gone wrong. The plugins should be built from the top-level >> directory instead (see below how it works for me), with the regular >> "make" that also builds openvpn, so the "for plugin in ... make -C >> $plugin ..." is no longer needed for

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

If the patch is applied, the libtoolize tool has populated m4/* and you've regenerated the aclocal.m4 with aclocal, the configure and Makefile.in, then it should suffice, yes. I am more than willing to send you my spec file for you to look at and can also attach instructions on how to try to

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

Can you toss your .spec file around? Just sent privately!

Re: [Openvpn-devel] bugfix2.1: automake support for plugin build

Am 07.01.2011 00:12, schrieb Mr Dash Four: > >> If the patch is applied, the libtoolize tool has populated m4/* and you've >> regenerated the aclocal.m4 with aclocal, the configure and Makefile.in, then >> it >> should suffice, yes. >> > I am more than willing to send you my spec file for you

Re: [Openvpn-devel] beta2.2: automake support for plugin build

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/01/11 23:53, Matthias Andree wrote: | Am 06.01.2011 22:50, schrieb David Sommerseth: |> On 06/01/11 18:13, Matthias Andree wrote: |> | Greetings, |> | |> | this is the beta2.2 patch pair for hooking the auth-pam and down-root |> | plugins to the