Re: [Openvpn-devel] [PATCH] Choose a different field in X509 to be username

David Sommerseth wrote: > > 3) "sizeof(common_name)" is useless... Line 745: char > > common_name[TLS_USERNAME_LEN]; we can use directly TLS_USERNAME_LEN. > > Thanks a lot for the patch and all rework done. (Also: thank you to all > reviewers!) > > The third and last patch looks very good! I've

Re: [Openvpn-devel] [PATCH] Choose a different field in X509 to be username

Am 17.06.2010, 15:57 Uhr, schrieb Alon Bar-Lev: Great. Few more: 1. To upper: char *s = p[1]; while ((*s = toupper(*s)) != '\0') s++; I haven't looked at the patch yet, so my silence about anything else DOES NOT constitute approval or anything of the remainder of the code. Picking out a

[Openvpn-devel] Renaming all vars/function "common_name".

Hi, Related to my previous patch, we talked about renaming all "common_name" vars et functions. My first suggestion was to rename it "username", but it's too vague. Alon and David suggested to use "x509_" as prefix for this "new" var name. But it seems to me, the server verification is don

[Openvpn-devel] Summary of the IRC meeting (17th Jun 2010)

Hi, Here's the summary of the previous community meeting. --- COMMUNITY MEETING Place: #openvpn-devel on irc.freenode.net List-Post: openvpn-devel@lists.sourceforge.net Date: Thursday, 17th Jun 2010 Time: 18:00 UTC Planned meeting topics for this meeting were on this page: