Re: [Openvpn-devel] [PATCH v4] Use CryptoAPI CA store (was Re: [PATCH v3] Use CryptoAPI CA store)

2008-10-07 Thread Alon Bar-Lev
Any news? On 9/27/08, Alon Bar-Lev wrote: > Hi! > > I prefer to receive patches... > Anyway, this is not exactly what I meant. > Please review latest head. > I did not test this, but it should be correct now as far as the > changes are concerned. > It may not work as the validation process

Re: [Openvpn-devel] [PATCH v4] Use CryptoAPI CA store (was Re: [PATCH v3] Use CryptoAPI CA store)

2008-10-07 Thread Alon Bar-Lev
On 10/7/08, Faidon Liambotis wrote: > Thanks for reviving this. I built it and tried it and seems to work. > I didn't test with revoked or expired certificates, however. > > As for warnings there's just a trivial one: > cryptoapi.c:429: warning: passing arg 2 of `d2i_X509' from >

Re: [Openvpn-devel] [PATCH v4] Use CryptoAPI CA store (was Re: [PATCH v3] Use CryptoAPI CA store)

2008-10-07 Thread Faidon Liambotis
Hi, Alon Bar-Lev wrote: > On 9/27/08, Alon Bar-Lev wrote: >> I prefer to receive patches... >> Anyway, this is not exactly what I meant. >> Please review latest head. >> I did not test this, but it should be correct now as far as the >> changes are concerned. >> It may not work as the valid

Re: [Openvpn-devel] [PATCH v4] Use CryptoAPI CA store (was Re: [PATCH v3] Use CryptoAPI CA store)

2008-10-07 Thread Jason R. Coombs
Faidon, If you send me a binary build for Windows 32-bit, I'll test it against expired and revoked certs. I presume I don't need a server configured for this test; it should fail client side before attempting to connect? Jason -Original Message- From: Faidon Liambotis [mailto:parav...

Re: [Openvpn-devel] [PATCH v4] Use CryptoAPI CA store (was Re: [PATCH v3] Use CryptoAPI CA store)

2008-10-07 Thread Alon Bar-Lev
Binaries are at [1]. It is not enough to test it on client, we need to verify that the validation works correctly on both ends, as capi has different policy for servers and clients. Alon. [1] http://alon.barlev.googlepages.com/openvpn-mscapi-test-1.tar.bz2 On 10/7/08, Jason R. Coombs wrote: >