Re: [Openvpn-devel] [Version 4] Merge getaddr_multi and getaddr6 into one function

2012-09-03 Thread Samuli Seppänen
> I ACK this, but please remember to tell your editor to use 8-character tabs, > as that is "what the rest of the code uses" - some of the new code looks > quite weird with ":set ts=8", and there's more diffs in there due to > whitespace changes (4 spaces getting converted into a single tab, like

Re: [Openvpn-devel] [Version 4] Merge getaddr_multi and getaddr6 into one function

2012-09-02 Thread David Sommerseth
On 07/08/12 12:03, Arne Schwabe wrote: > the getaddr6 and getaddr_mutli functions are duplicates of each other. Since > we always require getaddrinfo to be present both function are merge into one > openvpn_getaddrinfo. > > This functions also returns a standard struct addrinfo* so our resolve

Re: [Openvpn-devel] [Version 4] Merge getaddr_multi and getaddr6 into one function

2012-09-02 Thread Gert Doering
Hi, On Tue, Aug 07, 2012 at 12:03:57PM +0200, Arne Schwabe wrote: > the getaddr6 and getaddr_mutli functions are duplicates of each other. Since > we always require getaddrinfo to be present both function are merge into one > openvpn_getaddrinfo. > > This functions also returns a standard struc