Re: [Openvpn-devel] [PATCHv2 1/2] make non-blocking connect work on Windows

2012-07-19 Thread David Sommerseth
On 17/07/12 18:19, Heiko Hund wrote: > Instead of EINPROGRESS WinSock2 returns WSAEWOULDBLOCK if a non-blocking > connect(2) cannot be completed immediately. > > Signed-off-by: Heiko Hund > --- > src/openvpn/socket.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > Applied

Re: [Openvpn-devel] [PATCHv2 1/2] make non-blocking connect work on Windows

2012-07-18 Thread Alon Bar-Lev
I had time to look at the code, what I don't understand is how come we work none blocking and do not test for EWOULDBLOCK at other places... If I get it right, at least after send() we can get EWOULDBLOCK even if select() returned we have free buffers. On Wed, Jul 18, 2012 at 7:20 AM, Alon Bar-Lev

Re: [Openvpn-devel] [PATCHv2 1/2] make non-blocking connect work on Windows

2012-07-18 Thread Alon Bar-Lev
Thanks. I think this is the simplest solution to this issue. On Tue, Jul 17, 2012 at 7:19 PM, Heiko Hund wrote: > Instead of EINPROGRESS WinSock2 returns WSAEWOULDBLOCK if a non-blocking > connect(2) cannot be completed immediately. > > Signed-off-by: Heiko Hund > --- > src/openvpn/socket.c |

Re: [Openvpn-devel] [PATCHv2 1/2] make non-blocking connect work on Windows

2012-07-17 Thread Gert Doering
Hi, On Tue, Jul 17, 2012 at 06:19:53PM +0200, Heiko Hund wrote: > Instead of EINPROGRESS WinSock2 returns WSAEWOULDBLOCK if a non-blocking > connect(2) cannot be completed immediately. Feature-ACK (thanks for fixing :) ), and given the preceding discussion, code-ACK as well. gert -- USENET is