Re: [Openvpn-devel] [PATCHv2] Handle DNS6 option on Android

2016-11-22 Thread Gert Doering
Hi, On Tue, Nov 22, 2016 at 11:33:36AM -0500, Selva Nair wrote: > The code looks good to me, so ACK Beat you to it :) > (Note: the preferred comment closing style may be '*/' on a line by > itself?). Indeed it is. I overlooked that, otherwise I would have fixed it on the fly. Meh. gert --

Re: [Openvpn-devel] [PATCHv2] Handle DNS6 option on Android

2016-11-22 Thread Selva Nair
Hi, On Tue, Nov 22, 2016 at 6:38 AM, Arne Schwabe wrote: ... > - for (i = 0; i < tt->options.dns_len; ++i) { > + /* Prefer IPv6 DNS servers, > + * Android will use the DNS server in the order we specify*/ > + for (int i = 0; i < tt->options.dns6_len; i++) { > +management_android_control