Re: [Openvpn-devel] [PATCH v5] Cleanup handling of initial auth token

2021-07-19 Thread Arne Schwabe
>> /* >> * reuse the same session id and timestamp and null terminate it at >> * for base64 decode it only decodes the session id part of it >> */ > > This comment above does not make much sense to me, but since it has been > there since "ever", I'd suggest

Re: [Openvpn-devel] [PATCH v5] Cleanup handling of initial auth token

2021-07-18 Thread Antonio Quartulli
Hi, On 13/07/2021 14:25, Arne Schwabe wrote: > This changes that auth_token_initial is set when the token is > initially generated instead when pushing the token. Even I do not know > anymore why I did it in this way in the first place. Also use > multi->auth_token_initial as source for the sesssi