Re: [Openvpn-devel] [PATCH v3] Implement HMAC based session id for tls-crypt v2

2022-05-04 Thread Antonio Quartulli
Hi, On 02/05/2022 18:09, Arne Schwabe wrote: Tls-crypt v2 is more complicated to implement a proper stateless handshake. To allow state handshake this commit does - introduce a new packet CONTROL_WKC_V1 that repeats the wrapped client key. - introduce a way to negotiate the support for

Re: [Openvpn-devel] [PATCH v3] Implement HMAC based session id for tls-crypt v2

2022-05-03 Thread Frank Lichtenheld
Still found a few typos and whitespace issues, but no code issues. Overall this looks okay to me but I'm hesitant to actually ack it because I'm not sure of the potential implications of all the protocol hacks (i.e. the packet id flags and the TLV payload). > Arne Schwabe hat am 02.05.2022 18:09