Re: [Openvpn-devel] [PATCH v3] Enable stricter compiler warnings by default

2018-02-02 Thread David Sommerseth
On 02/02/18 07:32, Steffan Karger wrote: > Hi, > > On 02-02-18 05:43, Selva Nair wrote: >> On Thu, Feb 1, 2018 at 10:45 AM, Steffan Karger wrote: >>> [...] >>> >>> +AX_CHECK_COMPILE_FLAG([-Wall], [CFLAGS="-Wall ${CFLAGS}"]) >> >> The three options could have checked together, but this is fine too

Re: [Openvpn-devel] [PATCH v3] Enable stricter compiler warnings by default

2018-02-01 Thread Steffan Karger
Hi, On 02-02-18 05:43, Selva Nair wrote: > On Thu, Feb 1, 2018 at 10:45 AM, Steffan Karger wrote: >> [...] >> >> +AX_CHECK_COMPILE_FLAG([-Wall], [CFLAGS="-Wall ${CFLAGS}"]) > > The three options could have checked together, but this is fine too. > > All said and done, the check is not as useful

Re: [Openvpn-devel] [PATCH v3] Enable stricter compiler warnings by default

2018-02-01 Thread Selva Nair
Hi, On Thu, Feb 1, 2018 at 10:45 AM, Steffan Karger wrote: > This by default enables the compiler warnings one could previously > enable using the --enable-strict configure option. I think it is > okay to do so now, because we've taken care of many warnings in the > more standard builds. (Most

Re: [Openvpn-devel] [PATCH v3] Enable stricter compiler warnings by default

2018-02-01 Thread Steffan Karger
On 01-02-18 16:45, Steffan Karger wrote: > +AX_CHECK_COMPILE_FLAG( > +[-Wno-unused-function], > +[CFLAGS="-Wno-unused-function ${CFLAGS}"] > +) > +AX_CHECK_COMPILE_FLAG( > +[-Wno-unused-parameter], > +[CFLAGS="-Wno-unused-parameter ${CFLAGS}"] > +) Gah, those should have been tab-