Re: [Openvpn-devel] [PATCH v2 3/3] Replace deprecated LZ4 function

2017-07-10 Thread Antonio Quartulli
On 10/07/17 15:07, Gert Doering wrote: > Hi, > > On Mon, Jul 10, 2017 at 02:33:43PM +0800, Antonio Quartulli wrote: >> On 10/07/17 14:30, Gert Doering wrote: >>> On Mon, Jul 10, 2017 at 12:31:31PM +0800, Antonio Quartulli wrote: Instead of cluttering the code with these ifdefs directly in t

Re: [Openvpn-devel] [PATCH v2 3/3] Replace deprecated LZ4 function

2017-07-10 Thread Gert Doering
Hi, On Mon, Jul 10, 2017 at 02:33:43PM +0800, Antonio Quartulli wrote: > On 10/07/17 14:30, Gert Doering wrote: > > On Mon, Jul 10, 2017 at 12:31:31PM +0800, Antonio Quartulli wrote: > >> Instead of cluttering the code with these ifdefs directly in the main > >> codebase, how about doing it in com

Re: [Openvpn-devel] [PATCH v2 3/3] Replace deprecated LZ4 function

2017-07-09 Thread Antonio Quartulli
Hi, On 10/07/17 14:30, Gert Doering wrote: > Hi, > > On Mon, Jul 10, 2017 at 12:31:31PM +0800, Antonio Quartulli wrote: >> Instead of cluttering the code with these ifdefs directly in the main >> codebase, how about doing it in compat.h, like this (it's a copy/paste - >> code might be wrapper by

Re: [Openvpn-devel] [PATCH v2 3/3] Replace deprecated LZ4 function

2017-07-09 Thread Gert Doering
Hi, On Mon, Jul 10, 2017 at 12:31:31PM +0800, Antonio Quartulli wrote: > Instead of cluttering the code with these ifdefs directly in the main > codebase, how about doing it in compat.h, like this (it's a copy/paste - > code might be wrapper by the mail client): Better, but I wonder if we shouldn

Re: [Openvpn-devel] [PATCH v2 3/3] Replace deprecated LZ4 function

2017-07-09 Thread Antonio Quartulli
Hi, On 22/02/17 03:27, David Sommerseth wrote: > +#if defined LZ4_VERSION_NUMBER && LZ4_VERSION_NUMBER >= 10700 > +zlen = LZ4_compress_default((const char *)BPTR(buf), (char > *)BPTR(work), BLEN(buf), zlen_max ); > +#else > zlen = LZ4_compress_limitedOutput((const char *)BPTR(buf