Re: [Openvpn-devel] [PATCH v2] reload CRL only if file was modified

2016-12-01 Thread Steffan Karger
On 01-12-16 09:13, Steffan Karger wrote: > else if (0 != platform_stat(crl_file, &crl_stat)) > { > msg (M_WARN, "WARNING: Failed to stat CRL file, using cached CRL."); > } Ahum, as Gert noted on IRC, this missed a return statement to actually *not* load the CRL. So, better suggest

Re: [Openvpn-devel] [PATCH v2] reload CRL only if file was modified

2016-12-01 Thread Antonio Quartulli
On Thu, Dec 01, 2016 at 09:13:36AM +0100, Steffan Karger wrote: > Hi, > > Tested on linux and windows, works as expected, except for one thing: > > On 01-12-16 07:55, Antonio Quartulli wrote: > > + /* > > + * an inline CRL can't change at runtime, therefore there is no need to > > + * reload

Re: [Openvpn-devel] [PATCH v2] reload CRL only if file was modified

2016-12-01 Thread Steffan Karger
Hi, Tested on linux and windows, works as expected, except for one thing: On 01-12-16 07:55, Antonio Quartulli wrote: > + /* > + * an inline CRL can't change at runtime, therefore there is no need to > + * reload it. It will be reloaded upon config change + SIGHUP. > + * Use always '1' as