Re: [Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

2017-09-26 Thread Antonio Quartulli
On 26/09/17 00:22, Steffan Karger wrote: > Hi, > > On 21-09-17 23:03, David Sommerseth wrote: >> On 15/09/17 08:39, Steffan Karger wrote: >>> close_instance() tries to remove the file in c2.pf.filename, but that only >>> works if we actually set that if we fail. So, set that filename as soon >>

Re: [Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

2017-09-25 Thread Steffan Karger
Hi, On 21-09-17 23:03, David Sommerseth wrote: > On 15/09/17 08:39, Steffan Karger wrote: >> close_instance() tries to remove the file in c2.pf.filename, but that only >> works if we actually set that if we fail. So, set that filename as soon >> as we know we've created the file. >> >> Signed-off

Re: [Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

2017-09-21 Thread David Sommerseth
On 15/09/17 08:39, Steffan Karger wrote: > close_instance() tries to remove the file in c2.pf.filename, but that only > works if we actually set that if we fail. So, set that filename as soon > as we know we've created the file. > > Signed-off-by: Steffan Karger > --- > v2: As suggested by Antio

Re: [Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

2017-09-21 Thread Antonio Quartulli
On 15/09/17 14:39, Steffan Karger wrote: > close_instance() tries to remove the file in c2.pf.filename, but that only > works if we actually set that if we fail. So, set that filename as soon > as we know we've created the file. > > Signed-off-by: Steffan Karger > --- > v2: As suggested by Ant