Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-24 Thread Gert Doering
Hi, On Sat, Sep 23, 2017 at 10:52:16AM +0200, Simon Matter wrote: > > Feature-ACK (I think this is a useful idea, for the same reasons we have > > LZO and OpenSSL versions :-) ), but that will not work if we use > > compat-lz4.h, so "code NAK". > > IIRC at the time of writing this, the embedded l

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-23 Thread Simon Matter
> Hi, > > On Thu, Sep 07, 2017 at 10:40:21PM +0200, Simon Matter wrote: >> While we are at it, I found it useful to see the used LZ4 version at >> runtime as it is done with LZO and other libraries. >> >> I've patched my rpms with the patch attached. > [..] > >> diff -Naur openvpn-2.4.0.orig/src/op

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-22 Thread Gert Doering
Hi, On Thu, Sep 07, 2017 at 07:20:04PM +0200, David Sommerseth wrote: > We are using a deprecated function, LZ4_compress_limitedOutput(), which > will be removed with time. The correct function to use is > LZ4_compress_default(). > Both function takes the same number of arguments and data types,

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-22 Thread Gert Doering
Hi, On Thu, Sep 07, 2017 at 10:40:21PM +0200, Simon Matter wrote: > While we are at it, I found it useful to see the used LZ4 version at > runtime as it is done with LZO and other libraries. > > I've patched my rpms with the patch attached. [..] > diff -Naur openvpn-2.4.0.orig/src/openvpn/comp-l

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-21 Thread David Sommerseth
On 07/09/17 22:40, Simon Matter wrote: > Hi, > > While we are at it, I found it useful to see the used LZ4 version at > runtime as it is done with LZO and other libraries. > > I've patched my rpms with the patch attached. Thanks a lot! I think this makes sense. But I think we can do this stuff

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-07 Thread Antonio Quartulli
Hi, On 08/09/17 01:20, David Sommerseth wrote: [CUT] > diff --git a/src/openvpn/comp-lz4.c b/src/openvpn/comp-lz4.c > index e056caa8..bdb3247d 100644 > --- a/src/openvpn/comp-lz4.c > +++ b/src/openvpn/comp-lz4.c > @@ -43,6 +43,7 @@ > > #include "memdbg.h" > > + > static void > lz4_compres

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-07 Thread Simon Matter
Hi, While we are at it, I found it useful to see the used LZ4 version at runtime as it is done with LZO and other libraries. I've patched my rpms with the patch attached. Regards, Simon > We are using a deprecated function, LZ4_compress_limitedOutput(), which > will be removed with time. The c