Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-13 Thread Gert Doering
Hi, On Fri, Dec 11, 2015 at 10:29:33PM +0200, Lev Stipakov wrote: > Thanks, I think (I think!) I got it now. > > 1) Since we have tt->adapter_index (which temporarily disappeared from > my perception of reality), no need to add new member to tuntap or > tuntap_options. > > 2) tt->adapter_index

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-11 Thread Lev Stipakov
Thanks, I think (I think!) I got it now. 1) Since we have tt->adapter_index (which temporarily disappeared from my perception of reality), no need to add new member to tuntap or tuntap_options. 2) tt->adapter_index has nothing to do with rgi->adapter_index, first one is windows adapter index

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-11 Thread Gert Doering
Hi, On Fri, Dec 11, 2015 at 09:41:56PM +0200, Lev Stipakov wrote: > Hi, > > >> So, if we want to use index also for "add/del route", I'd gently modify > >> add/del_route_ipv6 and make it use "interface=" (without breaking > >> "vpn server special route" case). > > > > For consistency, I think we

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-11 Thread Lev Stipakov
Hi, So, if we want to use index also for "add/del route", I'd gently modify add/del_route_ipv6 and make it use "interface=" (without breaking "vpn server special route" case). For consistency, I think we should do that. What I'd avoid is to do the adapter_index lookup for every single route -

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-11-11 Thread Gert Doering
Hi, On Wed, Nov 11, 2015 at 10:05:11AM +0200, Lev Stipakov wrote: > > > > It should actually be not very hard - we should be able to set "tt->actual" > > to read "interface=nnn", and then it should work automagically without even > > touching route.c at all > > Setting "interface=" to "tt->actual

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-11-11 Thread Lev Stipakov
Hi, It should actually be not very hard - we should be able to set "tt->actual" to read "interface=nnn", and then it should work automagically without even touching route.c at all Setting "interface=" to "tt->actual_name" will affect all code branches which use that value, for example "netsh

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-11-09 Thread Gert Doering
Hi, On Mon, Nov 09, 2015 at 04:35:09PM +0200, Lev Stipakov wrote: > v2: > * Remove netsh call which uses adapter name. After thoughtful testing > turns out that "adapter name" code branch is never used. Not there yet :-) - but thanks for picking this up. As I said for v1, if we change this for