Re: [Openvpn-devel] [PATCH v2] Use P_DATA_V2 for server->client packets too

2017-11-24 Thread Gert Doering
Hi, as just discussed on IRC, I'm not fully happy with this, and want a v3... On Sun, Nov 12, 2017 at 06:22:37PM +0100, Steffan Karger wrote: [..] > diff --git a/src/openvpn/push.c b/src/openvpn/push.c > index 5947a31f..16a4101f 100644 > --- a/src/openvpn/push.c > +++ b/src/openvpn/push.c > @@ -

Re: [Openvpn-devel] [PATCH v2] Use P_DATA_V2 for server->client packets too

2017-11-12 Thread Antonio Quartulli
Hi, On 13/11/17 01:22, Steffan Karger wrote: > P_DATA_V2 introduced the peer-id. This allows clients to float, but as a > side-effect 32-bit aligns the encrypted data. That alignment improves > performance particularly on cheaper/older CPUs. So although servers don't > actually have a peer-id,