Re: [Openvpn-devel] [PATCH v2] Fix memory leaks in HMAC initial packet id

2023-03-15 Thread Gert Doering
Hi, On Wed, Mar 15, 2023 at 04:04:20PM +0100, Arne Schwabe wrote: > The HMAC leaks are just forgotten frees/deinitialisations. tls_wrap_control > will sometimes return the original buffer (non tls-crypt) and sometimes > tls_wrap.work, handling this buffer lifetime is a bit more complicated. > Ins

Re: [Openvpn-devel] [PATCH v2] Fix memory leaks in HMAC initial packet id and dco open tun

2023-03-13 Thread Gert Doering
Hi, On Mon, Mar 13, 2023 at 02:42:33PM +0100, Arne Schwabe wrote: > The open_tun_dco_generic already allocates the actual_name string, this > shadows the allocation in the FreeBSD/Linux specific methods. > > The HMAC leaks are just forgotten frees/deinitialisations. > > Found-By: clang with asan