Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Kristof Provost via Openvpn-devel
On 29 Jun 2022, at 21:08, Arne Schwabe wrote: > Am 29.06.2022 um 19:40 schrieb Kristof Provost: >> On 29 Jun 2022, at 17:15, Arne Schwabe wrote: >>> Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: Hi, Here's the most recent version of the FreeBSD DCO patch. This

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Arne Schwabe
Am 29.06.2022 um 19:40 schrieb Kristof Provost: On 29 Jun 2022, at 17:15, Arne Schwabe wrote: Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: Hi, Here's the most recent version of the FreeBSD DCO patch. This is based on top of the dco branch, at 480fa1c983aba9b0790ea94df209e16

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Kristof Provost via Openvpn-devel
On 29 Jun 2022, at 17:15, Arne Schwabe wrote: > Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: >> Hi, >> >> Here's the most recent version of the FreeBSD DCO patch. >> This is based on top of the dco branch, at >> 480fa1c983aba9b0790ea94df209e1686f08336b. >> >> Relatedly, the kerne

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-29 Thread Arne Schwabe
Am 28.06.22 um 18:28 schrieb Kristof Provost via Openvpn-devel: Hi, Here's the most recent version of the FreeBSD DCO patch. This is based on top of the dco branch, at 480fa1c983aba9b0790ea94df209e1686f08336b. Relatedly, the kernel side of that support has just landed in FreeBSD's repo: https:

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-28 Thread Kristof Provost via Openvpn-devel
On 28 Jun 2022, at 21:05, Antonio Quartulli wrote: > On 28/06/2022 18:28, Kristof Provost via Openvpn-devel wrote: >> Hi, >> >> Here's the most recent version of the FreeBSD DCO patch. >> This is based on top of the dco branch, at >> 480fa1c983aba9b0790ea94df209e1686f08336b. >> > > Thanks! DCO patc

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-06-28 Thread Antonio Quartulli
Hi, On 28/06/2022 18:28, Kristof Provost via Openvpn-devel wrote: Hi, Here's the most recent version of the FreeBSD DCO patch. This is based on top of the dco branch, at 480fa1c983aba9b0790ea94df209e1686f08336b. Thanks! DCO patches may still change a bit due to review, but their converging

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-03-08 Thread Arne Schwabe
Am 08.03.22 um 15:45 schrieb Kristof Provost via Openvpn-devel: On 8 Mar 2022, at 15:23, Antonio Quartulli wrote: On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: I've had to add a lot of '|| defined(TARGET_FREEBSD)', and I think the code could be a bit cleaner if we'd make these c

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-03-08 Thread Kristof Provost via Openvpn-devel
On 8 Mar 2022, at 15:23, Antonio Quartulli wrote: > On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: >> I've had to add a lot of '|| defined(TARGET_FREEBSD)', and I think the >> code could be a bit cleaner if we'd make these calls conditional only on >> defined(ENABLE_DCO), and instead

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-03-08 Thread Antonio Quartulli
Hi, On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: I've had to add a lot of '|| defined(TARGET_FREEBSD)', and I think the code could be a bit cleaner if we'd make these calls conditional only on defined(ENABLE_DCO), and instead expect every DCO implementation to provide them, if o