Re: [Openvpn-devel] [PATCH 6/7] argv: do fewer memory re-allocations

2017-11-11 Thread Heiko Hund
On Wednesday, November 9, 2016 11:58:21 PM CET David Sommerseth wrote: > > argv_init (struct argv *a) > > { > > > >a->capacity = 0; > >a->argc = 0; > >a->argv = NULL; > > > > + argv_extend (a, 8); > > Why 8? Done any performance and/or memory utilization tests? Does the > overa

Re: [Openvpn-devel] [PATCH 6/7] argv: do fewer memory re-allocations

2016-11-09 Thread David Sommerseth
On 28/10/16 18:42, Heiko Hund wrote: > Prevent the re-allocations of memory when the internal argv grows > beyond 2 and 4 arguments by initially allocating argv to hold up to > 7 (+ trailing NULL) pointers. > > While at it rename argv_reset to argv_free to actually express > what's going on. Redo