Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-28 Thread Antonio Quartulli
Hi², On 26/09/17 00:05, Steffan Karger wrote: > Hi, > > On 21-09-17 19:15, Antonio Quartulli wrote: >> On 15/09/17 05:34, Steffan Karger wrote: >>> diff --git a/src/openvpn/pf.c b/src/openvpn/pf.c >>> index 5cb002b..5fe1734 100644 >>> --- a/src/openvpn/pf.c >>> +++ b/src/openvpn/pf.c >>> @@ -639,

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-25 Thread Steffan Karger
Hi, On 21-09-17 19:15, Antonio Quartulli wrote: > On 15/09/17 05:34, Steffan Karger wrote: >> diff --git a/src/openvpn/pf.c b/src/openvpn/pf.c >> index 5cb002b..5fe1734 100644 >> --- a/src/openvpn/pf.c >> +++ b/src/openvpn/pf.c >> @@ -639,10 +639,10 @@ pf_init_context(struct context *c) >>

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-21 Thread David Sommerseth
On 14/09/17 23:34, Steffan Karger wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but just reject the connecting client. > > This commit changes the function to

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-21 Thread sameer.s.athaley
Please stop sending me mails u fools, this is not unsubscribing fed up of this. Remove my mail I'd for GOD sacks On 15-Sep-2017 3:05 AM, "Steffan Karger" wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In su

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-21 Thread Antonio Quartulli
Hi, On 15/09/17 05:34, Steffan Karger wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but just reject the connecting client. > > This commit changes the functio

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-14 Thread Antonio Quartulli
I just did a quick skim for now and I only have a codestyle comment below: On 15/09/17 05:34, Steffan Karger wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but