On Sun, Feb 14, 2016 at 10:26 PM, Arne Schwabe wrote:
> And we may need another patch for the Changes.rst
Woops, forgot this *again*... Attached a patch for Changes.rst. Feel
free to squash this into 8/10 when committing.
-Steffan
From d264096273b8213ac7d65fab000810b27dcae565 Mon Sep 17 00:00:
Am 14.02.16 um 21:59 schrieb Steffan Karger:
> Hi Arne,
>
> Thanks for reviewing. Attached a v2, and below inline responses to
> your remarks.
>
ACK. I looked through the changes and it is now good to go.
> On Wed, Feb 10, 2016 at 2:13 PM, Arne Schwabe wrote:
>>> AC_ARG_ENABLE(
>>> [aead-
Hi Arne,
Thanks for reviewing. Attached a v2, and below inline responses to
your remarks.
On Wed, Feb 10, 2016 at 2:13 PM, Arne Schwabe wrote:
>> AC_ARG_ENABLE(
>> [aead-modes],
>> [AS_HELP_STRING([--disable-aead-modes], [disable AEAD crypto modes
>> @<:@default=yes@:>@])],
>> ,
>>
Overall the code looks good and works well in my tests. A few remarks
(but ACK otherwise):
> AC_ARG_ENABLE(
> [aead-modes],
> [AS_HELP_STRING([--disable-aead-modes], [disable AEAD crypto modes
> @<:@default=yes@:>@])],
> ,
> [enable_aead_modes="yes"]
> )
I would not make this user
