> On Tue, Feb 21, 2012 at 12:39 AM, David Sommerseth
> wrote:
>> But remember that all your patches *will* go through review as for
>> everyone else in the community. That means either *1)* patch reviews on
>> the mailing list, or *2)* reviewed through a sprint review in a
>> developers meeting
No,
The alternate way is for people to go into github and start comment inline.
Did you ever tried to use github interface?
You see nice formatted patches and can comment on each line.
After we see we stabilize we send the lng patches to
the mailing list.
Trust me it won't be produc
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 20/02/12 23:47, Alon Bar-Lev wrote:
> Please start go over my patches in github[1] and mark your comments,
> this way we know if it was a total waste of time.
>
> Alon.
>
> [1] https://github.com/alonbl/openvpn
Alon,
If you want to have the rev
On Tue, Feb 21, 2012 at 12:39 AM, David Sommerseth
wrote:
> But remember that all your patches *will* go through review as for
> everyone else in the community. That means either *1)* patch reviews on
> the mailing list, or *2)* reviewed through a sprint review in a
> developers meeting on the IR
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 20/02/12 20:35, Alon Bar-Lev wrote:
> David,
>
> Again, This has nothing to do with POSIX. mingw *DOES* define this
> constant in *WINDOWS*.
You seem to ignore the fact that mingw provides an access() function
which *behaves* like the rest of the
I think that wrapping the whole access is one step farther...
The other two are better.
But it is still better than redefining X_OK... :)
Alon.
On Mon, Feb 20, 2012 at 11:32 PM, Gert Doering wrote:
> Hi,
>
> On Mon, Feb 20, 2012 at 10:44:31PM +0200, Alon Bar-Lev wrote:
>> It still touches the sa
Hi,
On Mon, Feb 20, 2012 at 10:44:31PM +0200, Alon Bar-Lev wrote:
> It still touches the same places...
>
> The difference is the usage:
> ---
> R_OK|PLATFORM_X_OK
> ---
> or:
> ---
> PLATFORM_MODE_MASK(R_OK | X_OK)
> ---
Nah, that's not the way it should be.
Given that we currently use X_OK on
It still touches the same places...
The difference is the usage:
---
R_OK|PLATFORM_X_OK
---
or:
---
PLATFORM_MODE_MASK(R_OK | X_OK)
---
On Mon, Feb 20, 2012 at 10:39 PM, Gert Doering wrote:
> Hi,
>
> On Mon, Feb 20, 2012 at 09:47:25PM +0200, Alon Bar-Lev wrote:
>> Another option is to use X_OK a
Hi,
On Mon, Feb 20, 2012 at 09:47:25PM +0200, Alon Bar-Lev wrote:
> Another option is to use X_OK and declare a macro
> PLATFORM_MASK_MODE(m)... whatever you think more readable.
This is something I would like better, as it localizes the change to
one place.
gert
--
USENET is *not* the non-clic
Another option is to use X_OK and declare a macro
PLATFORM_MASK_MODE(m)... whatever you think more readable.
On Mon, Feb 20, 2012 at 9:35 PM, Alon Bar-Lev wrote:
> David,
>
> Again,
> This has nothing to do with POSIX.
> mingw *DOES* define this constant in *WINDOWS*.
>
> We do not want to have a
David,
Again,
This has nothing to do with POSIX.
mingw *DOES* define this constant in *WINDOWS*.
We do not want to have a different constants (and different values) at
the MSVC and mingw build.
Build should be consistent when possible, but not override environment SDK.
Anyway, If this will not en
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 20/02/12 15:45, Alon Bar-Lev wrote:
> Reported by Heiko Hund. Reference [1].
>
> Replaces 4ebc587eab73e03ef64d344a5707d84e7f8d875a
>
> [1]
> http://msdn.microsoft.com/en-us/library/1w06ktdy%28v=vs.100%29.aspx
>
> Signed-off-by: Alon Bar-Lev ---
12 matches
Mail list logo
