Re: [Openvpn-devel] [PATCH] tests: Add a simple build sanity check

2017-08-19 Thread Steffan Karger
Hi, On 12-08-17 23:12, David Sommerseth wrote: > On 12/08/17 12:33, Steffan Karger wrote: > > [...] > >>> +check_option_count() >>> +{ >>> +num_min="$1" >>> +num_max="$2" >>> + >>> +echo -n "Checking if number of options are between $num_min and >>> $num_max ... " >>> +optcount=

Re: [Openvpn-devel] [PATCH] tests: Add a simple build sanity check

2017-08-12 Thread David Sommerseth
On 12/08/17 12:33, Steffan Karger wrote: [...] >> --- >> tests/Makefile.am | 2 +- >> tests/t_sanity_check.sh | 118 >> > > t_sanity_check is less descriptive than the t_usage proposed by Ilya. > (Sanity check could be anything, while we sp

Re: [Openvpn-devel] [PATCH] tests: Add a simple build sanity check

2017-08-12 Thread Steffan Karger
Hi, Some high-level comments: On 09-08-17 14:32, David Sommerseth wrote: > This runs openvpn --help to check if the output is somewhat > sensible and sane. It will catch if the binary segfaults, > if it is a normal build or an --enable-small build and > does some simple checks when a list of opt