Hi,
On Sun, Mar 28, 2021 at 02:03:37PM +0200, Tõivo Leedjärv wrote:
> The specific issue I ran into was getpass() having 8 character limit
> on Solaris/illumos.
Ah, thanks for that reminder. That is, indeed, a strong argument (and
who knows which other platforms might do this and we don't know a
Hi,
Thank you both for the review and feedback.
On Sun, Mar 28, 2021 at 10:52 AM Gert Doering wrote:
>
> On the necessity for the patch, I have mixed feelings - I do not see
> any OS remove getpass() any time soon, as it would break applications...
The specific issue I ran into was getpass() ha
Hi,
On 28/03/2021 10:52, Gert Doering wrote:
> [..]
>>> +{
>>> +(void) tcsetattr(fileno(fp), TCSAFLUSH, &tty_save);
>>
>> We should not need to cast to void - I don't think we have warnings set
>> for non-checked return values.
>
> Actually we should catch errors here and log them. I
Hi,
On Sun, Mar 28, 2021 at 01:52:51AM +0100, Antonio Quartulli wrote:
> I believe termios.h should normally be available on any *nix system,
> therefore it should be ok to switch to it.
Well, on everything that is recent enough to have tun/tap and sockets,
termios.h will exist.
On the necessity
Hi,
sorry if it took this long to get to this patch.
Unfortunately this patch should be rebased on master, because right now
it does not apply and I cannot test.
Can you please rebase and resubmit it (with v2 in the subject)?
However, I have some comments below.
On 13/01/2021 20:19, Tõivo Leedj
