Re: [Openvpn-devel] [PATCH] Set DNS Domain using iservice

2020-09-25 Thread Selva Nair
Hi Thanks for the review. On Fri, Sep 25, 2020 at 5:24 AM Lev Stipakov wrote: > Hi, > > > Note: this will set the domain twice if both v4 and v6 DNS > > servers are defined. It cant hurt, but could be avoided by > > making the domain setting a separate call from the DNS > > server setting. > >

Re: [Openvpn-devel] [PATCH] Set DNS Domain using iservice

2020-09-25 Thread Lev Stipakov
Hi, > Note: this will set the domain twice if both v4 and v6 DNS > servers are defined. It cant hurt, but could be avoided by > making the domain setting a separate call from the DNS > server setting. I think we should do that - there is no reason to make expensive call twice: $ time wmic niccon