Re: [Openvpn-devel] [PATCH] Improve ifconfig_sanity_check()

2016-12-09 Thread David Sommerseth
On 09/12/16 09:15, Gert Doering wrote: > Hi, > > On Fri, Dec 09, 2016 at 03:52:32AM +0100, David Sommerseth wrote: >> - Instead of checking the complete in_addr_t (which lacked proper htonl()), >> just do a simple peek at the last byte which contains the first octet >> of an IP address or subn

Re: [Openvpn-devel] [PATCH] Improve ifconfig_sanity_check()

2016-12-09 Thread Gert Doering
Hi, On Fri, Dec 09, 2016 at 03:52:32AM +0100, David Sommerseth wrote: > - Instead of checking the complete in_addr_t (which lacked proper htonl()), > just do a simple peek at the last byte which contains the first octet > of an IP address or subnet mask. Have you *tested* this on a non-intel